fix(pyramid): add missing http.response.status_code in duration metrics

The new convention for metrics use http.response.status_code in metrics for
http.server.request.duration metric:

https://opentelemetry.io/docs/specs/semconv/http/http-metrics/#metric-httpserverrequestduration

Only the old convention had the attribute for pyramid, but the new one was missing.

Author: dominod-dev

instrumentation/opentelemetry-instrumentation-pyramid/src/opentelemetry/instrumentation/pyramid/callbacks.py

@@ -43,6 +43,7 @@
 )
 from opentelemetry.semconv._incubating.attributes.http_attributes import (
     HTTP_STATUS_CODE,
+    HTTP_RESPONSE_STATUS_CODE,
 )
 from opentelemetry.semconv.attributes.http_attributes import HTTP_ROUTE
 from opentelemetry.semconv.metrics import MetricInstruments
@@ -265,9 +266,8 @@ def trace_tween(request):
             status = getattr(response, "status", status)
             status_code = otel_wsgi._parse_status_code(status)
             if status_code is not None:
-                duration_attrs[HTTP_STATUS_CODE] = (
-                    otel_wsgi._parse_status_code(status)
-                )
+                duration_attrs[HTTP_STATUS_CODE] = status_code
+                duration_attrs[HTTP_RESPONSE_STATUS_CODE] = status_code
 
             # Record metrics for old semconv (milliseconds)
             if duration_histogram_old:

instrumentation/opentelemetry-instrumentation-pyramid/tests/test_automatic.py

@@ -480,6 +480,7 @@ def _verify_metric_names(
 
     def _verify_duration_point(self, point):
         self.assertIn(HTTP_REQUEST_METHOD, point.attributes)
+        self.assertIn(HTTP_RESPONSE_STATUS_CODE, point.attributes)
         self.assertIn(URL_SCHEME, point.attributes)
         self.assertNotIn(HTTP_METHOD, point.attributes)
         self.assertNotIn(HTTP_SCHEME, point.attributes)