test: add coverage for the configuration attribute

Covers BaseInstrumentor.configuration defaulting to None and being
overridable on subclasses, and URLLib3Instrumentor's wiring of
URLLib3InstrumentorConfig as its configuration dataclass.

Author: ocelotl

instrumentation/opentelemetry-instrumentation-urllib3/tests/test_urllib3_integration.py

@@ -3,6 +3,7 @@
 
 import json
 import typing
+import unittest
 from unittest import mock
 
 import urllib3
@@ -19,6 +20,7 @@
 from opentelemetry.instrumentation.urllib3 import (
     RequestInfo,
     URLLib3Instrumentor,
+    URLLib3InstrumentorConfig,
 )
 from opentelemetry.instrumentation.utils import (
     suppress_http_instrumentation,
@@ -1022,3 +1024,29 @@ def test_urlopen_mixed_args(self):
         self.assertEqual(
             span.attributes["http.request.header.x_test"], ("Value",)
         )
+
+
+class TestURLLib3InstrumentorConfig(unittest.TestCase):
+    def test_configuration_attribute_is_config_dataclass(self):
+        self.assertIs(
+            URLLib3Instrumentor.configuration, URLLib3InstrumentorConfig
+        )
+
+    def test_default_fields_are_none(self):
+        config = URLLib3InstrumentorConfig()
+        self.assertIsNone(config.excluded_urls)
+        self.assertIsNone(config.captured_request_headers)
+        self.assertIsNone(config.captured_response_headers)
+        self.assertIsNone(config.sensitive_headers)
+
+    def test_fields_accept_declared_values(self):
+        config = URLLib3InstrumentorConfig(
+            excluded_urls="/healthz",
+            captured_request_headers=["X-Test"],
+            captured_response_headers=["X-Response"],
+            sensitive_headers=["Authorization"],
+        )
+        self.assertEqual(config.excluded_urls, "/healthz")
+        self.assertEqual(config.captured_request_headers, ["X-Test"])
+        self.assertEqual(config.captured_response_headers, ["X-Response"])
+        self.assertEqual(config.sensitive_headers, ["Authorization"])

opentelemetry-instrumentation/tests/test_instrumentor.py

@@ -2,6 +2,9 @@
 # SPDX-License-Identifier: Apache-2.0
 # type: ignore
 
+from __future__ import annotations
+
+from dataclasses import dataclass
 from logging import WARNING
 from unittest import TestCase
 from unittest.mock import patch
@@ -43,6 +46,21 @@ def test_protect(self):
     def test_singleton(self):
         self.assertIs(self.Instrumentor(), self.Instrumentor())
 
+    def test_configuration_defaults_to_none(self):
+        self.assertIsNone(BaseInstrumentor.configuration)
+        self.assertIsNone(self.Instrumentor().configuration)
+
+    def test_configuration_can_be_overridden(self):
+        @dataclass
+        class FooConfig:
+            bar: str | None = None
+
+        class ConfiguredInstrumentor(self.Instrumentor):
+            configuration = FooConfig
+
+        self.assertIs(ConfiguredInstrumentor.configuration, FooConfig)
+        self.assertIsNone(self.Instrumentor.configuration)
+
     @patch("opentelemetry.instrumentation.instrumentor._LOG")
     @patch(
         "opentelemetry.instrumentation.instrumentor.BaseInstrumentor._check_dependency_conflicts"