opentelemetry-instrumentation-pika: remove usage of deprecated SpanAttributes for net attributes (#4068)

* refactor: remove usage of deprecated SpanAttributes for net attributes

* update CHANGELOG.md

---------

Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>

Author: herin049

CHANGELOG.md

@@ -52,6 +52,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   ([#4057](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4057))
 - `opentelemetry-instrumentation-cassandra`: Replace SpanAttributes with semconv constants for DB attributes
   ([#4055](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4055))
+- `opentelemetry-instrumentation-pika`: Replace SpanAttributes with semconv constants for net attributes
+  ([#4068](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4068))
 - `opentelemetry-instrumentation-mysqlclient`: Replace SpanAttributes with semconv constants
   ([#4067](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4067))
 

instrumentation/opentelemetry-instrumentation-pika/src/opentelemetry/instrumentation/pika/utils.py

@@ -12,6 +12,10 @@
 from opentelemetry import context, propagate, trace
 from opentelemetry.instrumentation.utils import is_instrumentation_enabled
 from opentelemetry.propagators.textmap import CarrierT, Getter
+from opentelemetry.semconv._incubating.attributes.net_attributes import (
+    NET_PEER_NAME,
+    NET_PEER_PORT,
+)
 from opentelemetry.semconv.trace import (
     MessagingOperationValues,
     SpanAttributes,
@@ -184,19 +188,11 @@ def _enrich_span(
     if not channel:
         return
     if not hasattr(channel.connection, "params"):
-        span.set_attribute(
-            SpanAttributes.NET_PEER_NAME, channel.connection._impl.params.host
-        )
-        span.set_attribute(
-            SpanAttributes.NET_PEER_PORT, channel.connection._impl.params.port
-        )
+        span.set_attribute(NET_PEER_NAME, channel.connection._impl.params.host)
+        span.set_attribute(NET_PEER_PORT, channel.connection._impl.params.port)
     else:
-        span.set_attribute(
-            SpanAttributes.NET_PEER_NAME, channel.connection.params.host
-        )
-        span.set_attribute(
-            SpanAttributes.NET_PEER_PORT, channel.connection.params.port
-        )
+        span.set_attribute(NET_PEER_NAME, channel.connection.params.host)
+        span.set_attribute(NET_PEER_PORT, channel.connection.params.port)
 
 
 # pylint:disable=abstract-method

instrumentation/opentelemetry-instrumentation-pika/tests/test_utils.py

@@ -23,6 +23,10 @@
 from pika.spec import Basic, BasicProperties
 
 from opentelemetry.instrumentation.pika import utils
+from opentelemetry.semconv._incubating.attributes.net_attributes import (
+    NET_PEER_NAME,
+    NET_PEER_PORT,
+)
 from opentelemetry.semconv.trace import (
     MessagingOperationValues,
     SpanAttributes,
@@ -115,11 +119,11 @@ def test_enrich_span_basic_values() -> None:
                     properties.correlation_id,
                 ),
                 mock.call(
-                    SpanAttributes.NET_PEER_NAME,
+                    NET_PEER_NAME,
                     channel.connection.params.host,
                 ),
                 mock.call(
-                    SpanAttributes.NET_PEER_PORT,
+                    NET_PEER_PORT,
                     channel.connection.params.port,
                 ),
             ],
@@ -167,11 +171,11 @@ def test_enrich_span_unique_connection() -> None:
             any_order=True,
             calls=[
                 mock.call(
-                    SpanAttributes.NET_PEER_NAME,
+                    NET_PEER_NAME,
                     channel.connection._impl.params.host,
                 ),
                 mock.call(
-                    SpanAttributes.NET_PEER_PORT,
+                    NET_PEER_PORT,
                     channel.connection._impl.params.port,
                 ),
             ],