Move system dependencies intall to workflow

And make ms sql odbc driver optional so you can run tests locally
without accepting the EULA.

Author: xrmx

.github/workflows/generate_workflows_lib/src/generate_workflows_lib/misc.yml.j2

@@ -68,6 +68,12 @@ jobs:
       - name: Install tox
         run: pip install tox-uv
 
+      {%- if job_data == "docker-tests" %}
+
+      - name: Install Microsft SQL ODBC driver
+        run: sudo apt update -y && ACCEPT_EULA=Y sudo apt install -y msodbcsql18 unixodbc-dev unixodbc
+      {%- endif %}
+
       - name: Run tests
         run: tox -e {{ job_data }}
       {%- if job_data == "generate-workflows" %}

.github/workflows/misc.yml

@@ -58,6 +58,8 @@ jobs:
 
       - name: Install tox
         run: pip install tox-uv
+      - name: Install Microsft SQL ODBC driver
+        run: ACCEPT_EULA=Y sudo apt install -y msodbcsql18 unixodbc-dev unixodbc
 
       - name: Run tests
         run: tox -e docker-tests

tests/opentelemetry-docker-tests/tests/check_availability.py

@@ -130,8 +130,11 @@ def check_docker_services_availability():
     check_mysql_connection()
     check_postgres_connection()
     check_redis_connection()
-    check_mssql_connection()
-    setup_mssql_db()
+
+    # make accepting EULA for ms sql odbc driver optional
+    if "ODBC Driver 18 for SQL Server" in pyodbc.drivers():
+        check_mssql_connection()
+        setup_mssql_db()
 
 
 check_docker_services_availability()

tests/opentelemetry-docker-tests/tests/sqlalchemy_tests/test_mssql.py

@@ -3,6 +3,7 @@
 
 import os
 
+import pyodbc
 import pytest
 from sqlalchemy.exc import ProgrammingError
 
@@ -30,6 +31,10 @@
 }
 
 
+@pytest.mark.skipif(
+    "ODBC Driver 18 for SQL Server" not in pyodbc.drivers(),
+    reason="No MS SQL odbc driver installed",
+)
 class MssqlConnectorTestCase(SQLAlchemyTestMixin):
     """TestCase for pyodbc engine"""
 

tox.ini

@@ -1088,11 +1088,8 @@ allowlist_externals =
   sh
 
 commands_pre =
-  ; this assumes an ubuntu system
-  sh -c "sudo apt update -y"
-  sh -c "docker --version || sudo apt install -y docker.io docker-compose-v2"
-  sh -c "sudo ACCEPT_EULA=Y apt install -y msodbcsql18 unixodbc-dev unixodbc"
-  python -c "import pyodbc; print(pyodbc.drivers())"
+  sh -c "docker --version || echo "Docker with compose subcommand is required" && /bin/false"
+  sh -c "python -c 'import pyodbc; print(pyodbc.drivers())' || echo "You need to install unixODBC"
   docker compose up -d
   python check_availability.py