Fix pylint false positives for ThreadPoolExecutor and Future

Author: srikaaviya

instrumentation/opentelemetry-instrumentation-asyncio/tests/test_asyncio_run_coroutine_threadsafe.py

@@ -13,9 +13,10 @@
 # limitations under the License.
 import asyncio
 import threading
-from concurrent.futures import (  # pylint: disable=no-name-in-module; TODO #4199
-    ThreadPoolExecutor,
-)
+# from concurrent.futures import (  # pylint: disable=no-name-in-module; TODO #4199
+#     ThreadPoolExecutor,
+# )
+import concurrent.futures
 from unittest.mock import patch
 
 # pylint: disable=no-name-in-module
@@ -35,7 +36,7 @@ def setUp(self):
         super().setUp()
         AsyncioInstrumentor().instrument()
         self.loop = asyncio.new_event_loop()
-        self.executor = ThreadPoolExecutor(max_workers=1)
+        self.executor = concurrent.futures.ThreadPoolExecutor(max_workers=1)
         self.loop.set_default_executor(self.executor)
         self.thread = threading.Thread(target=self.loop.run_forever)
         self.thread.start()

instrumentation/opentelemetry-instrumentation-threading/tests/test_threading.py

@@ -13,9 +13,11 @@
 # limitations under the License.
 
 import threading
-from concurrent.futures import (  # pylint: disable=no-name-in-module; TODO #4199
-    ThreadPoolExecutor,
-)
+# from concurrent.futures import (  # pylint: disable=no-name-in-module; TODO #4199
+#     ThreadPoolExecutor,
+# )
+
+import concurrent.futures
 from typing import List
 from unittest.mock import MagicMock, patch
 
@@ -63,7 +65,7 @@ def test_trace_context_propagation_in_thread_pool_with_multiple_workers(
         self,
     ):
         max_workers = 10
-        executor = ThreadPoolExecutor(max_workers=max_workers)
+        executor = concurrent.futures.ThreadPoolExecutor(max_workers=max_workers)
 
         expected_span_contexts: List[trace.SpanContext] = []
         futures_list = []
@@ -83,7 +85,7 @@ def test_trace_context_propagation_in_thread_pool_with_multiple_workers(
 
     def test_trace_context_propagation_in_thread_pool_with_single_worker(self):
         max_workers = 1
-        with ThreadPoolExecutor(max_workers=max_workers) as executor:
+        with concurrent.futures.ThreadPoolExecutor(max_workers=max_workers) as executor:
             # test propagation of the same trace context across multiple tasks
             with self._tracer.start_as_current_span("task") as task_span:
                 expected_task_context = task_span.get_span_context()
@@ -271,7 +273,7 @@ def test_threading_with_valid_context_token(self, mock_detach: MagicMock):
     def test_thread_pool_with_none_context_token(self, mock_detach: MagicMock):
         with (
             self.get_root_span(),
-            ThreadPoolExecutor(max_workers=1) as executor,
+            concurrent.futures.ThreadPoolExecutor(max_workers=1) as executor,
         ):
             future = executor.submit(self.get_current_span_context_for_test)
             future.result()
@@ -289,7 +291,7 @@ def test_thread_pool_with_none_context_token(self, mock_detach: MagicMock):
     def test_threadpool_with_valid_context_token(self, mock_detach: MagicMock):
         with (
             self.get_root_span(),
-            ThreadPoolExecutor(max_workers=1) as executor,
+            concurrent.futures.ThreadPoolExecutor(max_workers=1) as executor,
         ):
             future = executor.submit(self.get_current_span_context_for_test)
             future.result()

test_pylint.py

@@ -0,0 +1 @@
+from concurrent.futures import ThreadPoolExecutor

util/opentelemetry-util-genai/src/opentelemetry/util/genai/_upload/completion_hook.py

@@ -22,10 +22,11 @@
 import posixpath
 import threading
 from collections import OrderedDict
-from concurrent.futures import (  # pylint: disable=no-name-in-module; TODO #4199
-    Future,
-    ThreadPoolExecutor,
-)
+# from concurrent.futures import (  # pylint: disable=no-name-in-module; TODO #4199
+#     Future,
+#     ThreadPoolExecutor,
+# )
+import concurrent.futures
 from contextlib import ExitStack
 from dataclasses import asdict, dataclass
 from functools import partial
@@ -159,13 +160,13 @@ def __init__(
 
         # Use a ThreadPoolExecutor for its queueing and thread management. The semaphore
         # limits the number of queued tasks. If the queue is full, data will be dropped.
-        self._executor = ThreadPoolExecutor(
+        self._executor = concurrent.futures.ThreadPoolExecutor(
             max_workers=min(self._max_queue_size, 64)
         )
         self._semaphore = threading.BoundedSemaphore(self._max_queue_size)
 
     def _submit_all(self, upload_data: UploadData) -> None:
-        def done(future: Future[None]) -> None:
+        def done(future: concurrent.futures.Future[None]) -> None:
             try:
                 future.result()
             except Exception:  # pylint: disable=broad-except