update tests to use named params

Author: lmolkova

util/opentelemetry-util-genai/tests/test_handler_workflow.py

@@ -48,28 +48,28 @@ class TelemetryHandlerWorkflowTest(_WorkflowTestBase):
     # ------------------------------------------------------------------
 
     def test_start_workflow_creates_span(self) -> None:
-        invocation = self.handler.start_workflow("my_workflow")
+        invocation = self.handler.start_workflow(name="my_workflow")
         self.assertIsNot(invocation.span, INVALID_SPAN)
         invocation.stop()
 
     def test_start_workflow_span_name(self) -> None:
-        invocation = self.handler.start_workflow("my_pipeline")
+        invocation = self.handler.start_workflow(name="my_pipeline")
         invocation.stop()
 
         spans = self._get_finished_spans()
         self.assertEqual(len(spans), 1)
         self.assertEqual(spans[0].name, "invoke_workflow my_pipeline")
 
     def test_start_workflow_span_name_without_name(self) -> None:
-        invocation = self.handler.start_workflow(None)
+        invocation = self.handler.start_workflow(name=None)
         invocation.stop()
 
         spans = self._get_finished_spans()
         self.assertEqual(len(spans), 1)
         self.assertEqual(spans[0].name, "invoke_workflow")
 
     def test_start_workflow_span_kind_is_internal(self) -> None:
-        invocation = self.handler.start_workflow("wf")
+        invocation = self.handler.start_workflow(name="wf")
         invocation.stop()
 
         spans = self._get_finished_spans()
@@ -78,7 +78,7 @@ def test_start_workflow_span_kind_is_internal(self) -> None:
 
     def test_start_workflow_records_monotonic_start(self) -> None:
         with patch("timeit.default_timer", return_value=500.0):
-            invocation = self.handler.start_workflow("wf")
+            invocation = self.handler.start_workflow(name="wf")
         self.assertEqual(invocation._monotonic_start_s, 500.0)
         invocation.stop()
 
@@ -87,14 +87,14 @@ def test_start_workflow_records_monotonic_start(self) -> None:
     # ------------------------------------------------------------------
 
     def test_stop_workflow_ends_span(self) -> None:
-        invocation = self.handler.start_workflow("wf")
+        invocation = self.handler.start_workflow(name="wf")
         invocation.stop()
 
         spans = self._get_finished_spans()
         self.assertEqual(len(spans), 1)
 
     def test_stop_workflow_sets_operation_name_attribute(self) -> None:
-        invocation = self.handler.start_workflow("wf")
+        invocation = self.handler.start_workflow(name="wf")
         invocation.stop()
 
         spans = self._get_finished_spans()
@@ -104,15 +104,15 @@ def test_stop_workflow_sets_operation_name_attribute(self) -> None:
         )
 
     def test_stop_workflow_sets_custom_attributes(self) -> None:
-        invocation = self.handler.start_workflow("wf")
+        invocation = self.handler.start_workflow(name="wf")
         invocation.attributes["custom.key"] = "custom_value"
         invocation.stop()
 
         spans = self._get_finished_spans()
         self.assertEqual(spans[0].attributes["custom.key"], "custom_value")
 
     def test_stop_workflow_returns_invocation(self) -> None:
-        invocation = self.handler.start_workflow("wf")
+        invocation = self.handler.start_workflow(name="wf")
         invocation.stop()
         spans = self._get_finished_spans()
         self.assertEqual(len(spans), 1)
@@ -122,7 +122,7 @@ def test_stop_workflow_returns_invocation(self) -> None:
     # ------------------------------------------------------------------
 
     def test_fail_workflow_sets_error_status(self) -> None:
-        invocation = self.handler.start_workflow("wf")
+        invocation = self.handler.start_workflow(name="wf")
         error = Error(message="something broke", type=RuntimeError)
         invocation.fail(error)
 
@@ -132,15 +132,15 @@ def test_fail_workflow_sets_error_status(self) -> None:
         self.assertEqual(spans[0].status.description, "something broke")
 
     def test_fail_workflow_sets_error_type_attribute(self) -> None:
-        invocation = self.handler.start_workflow("wf")
+        invocation = self.handler.start_workflow(name="wf")
         error = Error(message="bad", type=ValueError)
         invocation.fail(error)
 
         spans = self._get_finished_spans()
         self.assertEqual(spans[0].attributes["error.type"], "ValueError")
 
     def test_fail_workflow_sets_operation_name_attribute(self) -> None:
-        invocation = self.handler.start_workflow("wf")
+        invocation = self.handler.start_workflow(name="wf")
         error = Error(message="fail", type=TypeError)
         invocation.fail(error)
 
@@ -151,7 +151,7 @@ def test_fail_workflow_sets_operation_name_attribute(self) -> None:
         )
 
     def test_fail_workflow_ends_span(self) -> None:
-        invocation = self.handler.start_workflow("wf")
+        invocation = self.handler.start_workflow(name="wf")
         invocation.fail(Error(message="err", type=RuntimeError))
         spans = self._get_finished_spans()
         self.assertEqual(len(spans), 1)

util/opentelemetry-util-genai/tests/test_workflow_invocation.py

@@ -24,7 +24,7 @@ def setUp(self):
         self.handler = TelemetryHandler(tracer_provider=tracer_provider)
 
     def test_default_values(self):
-        invocation = self.handler.start_workflow(None)
+        invocation = self.handler.start_workflow(name=None)
         invocation.stop()
         assert invocation.name is None
         assert invocation._operation_name == "invoke_workflow"
@@ -42,7 +42,7 @@ def test_custom_name(self):
 
     def test_with_input_messages(self):
         msg = InputMessage(role="user", parts=[Text(content="hello")])
-        invocation = self.handler.start_workflow("test")
+        invocation = self.handler.start_workflow(name="test")
         invocation.input_messages = [msg]
         invocation.stop()
         assert len(invocation.input_messages) == 1
@@ -52,14 +52,14 @@ def test_with_output_messages(self):
         msg = OutputMessage(
             role="assistant", parts=[Text(content="hi")], finish_reason="stop"
         )
-        invocation = self.handler.start_workflow("test")
+        invocation = self.handler.start_workflow(name="test")
         invocation.output_messages = [msg]
         invocation.stop()
         assert len(invocation.output_messages) == 1
         assert invocation.output_messages[0].finish_reason == "stop"
 
     def test_inherits_genai_invocation(self):
-        invocation = self.handler.start_workflow("test")
+        invocation = self.handler.start_workflow(name="test")
         invocation.attributes["key"] = "value"
         invocation.stop()
         spans = self.span_exporter.get_finished_spans()
@@ -68,16 +68,16 @@ def test_inherits_genai_invocation(self):
 
     def test_default_lists_are_independent(self):
         """Ensure separate invocations get separate list instances."""
-        inv1 = self.handler.start_workflow(None)
-        inv2 = self.handler.start_workflow(None)
+        inv1 = self.handler.start_workflow(name=None)
+        inv2 = self.handler.start_workflow(name=None)
         inv1.input_messages.append(InputMessage(role="user", parts=[]))
         assert len(inv2.input_messages) == 0
         inv1.stop()
         inv2.stop()
 
     def test_default_attributes_are_independent(self):
-        inv1 = self.handler.start_workflow(None)
-        inv2 = self.handler.start_workflow(None)
+        inv1 = self.handler.start_workflow(name=None)
+        inv2 = self.handler.start_workflow(name=None)
         inv1.attributes["foo"] = "bar"
         assert "foo" not in inv2.attributes
         inv1.stop()
@@ -90,7 +90,7 @@ def test_full_construction(self):
             parts=[Text(content="answer")],
             finish_reason="stop",
         )
-        invocation = self.handler.start_workflow("my_workflow")
+        invocation = self.handler.start_workflow(name="my_workflow")
         invocation.input_messages = [inp]
         invocation.output_messages = [out]
         invocation.stop()