You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: AGENTS.md
+1Lines changed: 1 addition & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -65,6 +65,7 @@ uv run tox -e typecheck
65
65
- The monorepo uses `uv` workspaces.
66
66
-`tox.ini` defines the test matrix - check it for available test environments.
67
67
- Do not add `type: ignore` comments. If a type error arises, solve it properly or write a follow-up plan to address it in another PR.
68
+
- Annotate function signatures (parameters and return types) and class attributes. Prefer `from __future__ import annotations` over runtime-quoted strings.
68
69
- When a file uses `from __future__ import annotations`, do not quote type annotations just to
69
70
avoid forward references. Keep quotes only for expressions still evaluated at runtime, such as
70
71
`typing.cast(...)`, unless the referenced type is imported at runtime.
Copy file name to clipboardExpand all lines: CHANGELOG.md
+15Lines changed: 15 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -2,13 +2,23 @@
2
2
3
3
All notable changes to this project will be documented in this file.
4
4
5
+
<!--
6
+
Do *NOT* add changelog entries here!
7
+
8
+
This changelog is managed by towncrier and is compiled at release time.
9
+
10
+
See https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/CONTRIBUTING.md#changelog for details.
11
+
-->
12
+
5
13
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
6
14
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
7
15
8
16
> [!NOTE]
9
17
> The following components are released independently and maintain individual CHANGELOG files.
10
18
> Use [this search for a list of all CHANGELOG.md files in this repo](https://github.com/search?q=repo%3Aopen-telemetry%2Fopentelemetry-python-contrib+path%3A**%2FCHANGELOG.md&type=code).
11
19
20
+
<!-- changelog start -->
21
+
12
22
## Unreleased
13
23
14
24
### Added
@@ -126,6 +136,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+37-1Lines changed: 37 additions & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -247,10 +247,46 @@ A PR is considered to be **ready to merge** when:
247
247
reasonable time to review.
248
248
* Trivial change (typo, cosmetic, doc, etc.) doesn't have to wait for one day.
249
249
* Urgent fix can take exception as long as it has been actively communicated.
250
-
* A changelog entry is added to the corresponding changelog for the code base, if there is any impact on behavior. e.g. doc entries are not required, but small bug entries are.
250
+
* A changelog fragment is added (see [Changelog](#changelog) below), if there is any impact on behavior. e.g. doc entries are not required, but small bug entries are.
251
251
252
252
Any Approver / Maintainer can merge the PR once it is **ready to merge**.
253
253
254
+
### Changelog
255
+
256
+
This project uses [towncrier](https://towncrier.readthedocs.io/) to manage changelogs. Instead of editing `CHANGELOG.md` directly, each PR should include a changelog fragment file.
257
+
258
+
**Where to add fragments:**
259
+
260
+
-**Coordinated packages** (most instrumentations, exporters, propagators): add to the root `.changelog/` directory
261
+
-**Independently released packages** (`opentelemetry-opamp-client`, `opentelemetry-propagator-aws-xray`, `opentelemetry-resource-detector-azure`, `opentelemetry-sdk-extension-aws`): add to `<package>/.changelog/`
262
+
263
+
**Creating a changelog fragment:**
264
+
265
+
Create a file named `.changelog/<PR_NUMBER>.<TYPE>` where `TYPE` is one of: `added`, `changed`, `deprecated`, `removed`, `fixed`.
266
+
267
+
The file should contain a one-line description of the change. For example, `.changelog/1234.fixed`:
268
+
269
+
```
270
+
`opentelemetry-instrumentation-flask`: fix request hook not being called for websocket connections
271
+
```
272
+
273
+
**Writing a good changelog entry:**
274
+
275
+
- Write in imperative tone, as if completing the phrase "This change will..."
276
+
- Keep entries concise — ideally under 80 characters
277
+
- Prefix with the affected package name (e.g. `` `opentelemetry-instrumentation-flask`: ... ``)
278
+
- Don't include the PR number — towncrier adds it automatically
279
+
280
+
**Preview the changelog:**
281
+
282
+
```console
283
+
towncrier build --draft --version Unreleased
284
+
```
285
+
286
+
The CI will verify that a changelog fragment exists and that `CHANGELOG.md` files are not directly modified.
287
+
288
+
If your change does not need a changelog entry, add the "Skip Changelog" label to the PR.
289
+
254
290
### Stale PRs
255
291
256
292
PRs with no activity for 14 days will be automatically marked as stale and closed after a further 14 days of inactivity. To prevent a PR from being marked stale, ensure there is regular activity (commits, comments, reviews, etc).
0 commit comments