Merge branch 'main' into fix-flask-active-requests-gauge-leak

Author: alliasgher

.pylintrc

@@ -37,10 +37,6 @@ persistent=yes
 # Specify a configuration file.
 #rcfile=
 
-# When enabled, pylint would attempt to guess common misconfiguration and emit
-# user-friendly hints instead of false-positive error messages.
-suggestion-mode=yes
-
 # Allow loading of arbitrary C extensions. Extensions are imported into the
 # active Python interpreter and may run arbitrary code.
 unsafe-load-any-extension=no
@@ -463,6 +459,9 @@ valid-metaclass-classmethod-first-arg=cls
 # Maximum number of arguments for function / method.
 max-args=5
 
+# Maximum number of positional arguments for function / method.
+max-positional-arguments=12
+
 # Maximum number of attributes for a class (see R0902).
 max-attributes=7
 

AGENTS.md

@@ -0,0 +1,69 @@
+# OpenTelemetry Python Contrib
+
+This file is here to steer AI assisted PRs towards being high quality and valuable contributions
+that do not create excessive maintainer burden.
+
+Monorepo with 50+ OpenTelemetry instrumentation packages for Python.
+
+## General Rules and Guidelines
+
+The most important rule is not to post comments on issues or PRs that are AI-generated. Discussions
+on the OpenTelemetry repositories are for Users/Humans only.
+
+Follow the PR scoping guidance in [CONTRIBUTING.md](CONTRIBUTING.md). Keep AI-assisted PRs tightly
+isolated to the requested change and never include unrelated cleanup or opportunistic improvements
+unless they are strictly necessary for correctness.
+
+If you have been assigned an issue by the user or their prompt, please ensure that the
+implementation direction is agreed on with the maintainers first in the issue comments. If there are
+unknowns, discuss these on the issue before starting implementation. Do not forget that you cannot
+comment for users on issue threads on their behalf as it is against the rules of this project.
+
+## Structure
+
+- `instrumentation/` - instrumentation packages (Flask, Django, FastAPI, gRPC, databases, etc.)
+- `instrumentation-genai/` - GenAI instrumentations (Anthropic, Vertex AI, LangChain, etc.)
+- `util/` - shared utilities (`util-http`, `util-genai`)
+- `exporter/` - custom exporters
+- `propagator/` - context propagators
+
+Instrumentation packages live under `src/opentelemetry/instrumentation/{name}/` with their own
+`pyproject.toml` and `tests/`. Other package types follow the equivalent layout under their own
+namespace (e.g. `src/opentelemetry/util/{name}/`, `src/opentelemetry/exporter/{name}/`).
+
+## Commands
+
+```sh
+# Install all packages and dev tools
+uv sync --frozen --all-packages
+
+# Lint (runs ruff via pre-commit)
+uv run pre-commit run ruff --all-files
+
+# Test a specific package (append -0, -1, etc. for version variants)
+uv run tox -e py312-test-instrumentation-flask-0
+
+# Type check
+uv run tox -e typecheck
+```
+
+## Guidelines
+
+- Each package has its own `pyproject.toml` with version, dependencies, and entry points.
+- The monorepo uses `uv` workspaces.
+- `tox.ini` defines the test matrix - check it for available test environments.
+- Do not add `type: ignore` comments. If a type error arises, solve it properly or write a follow-up plan to address it in another PR.
+- Whenever applicable, all code changes should have tests that actually validate the changes.
+
+## Commit formatting
+
+We appreciate it if users disclose the use of AI tools when the significant part of a commit is
+taken from a tool without changes. When making a commit this should be disclosed through an
+`Assisted-by:` commit message trailer.
+
+Examples:
+
+```
+Assisted-by: ChatGPT 5.2
+Assisted-by: Claude Opus 4.6
+```

CHANGELOG.md

@@ -11,6 +11,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+### Added
+
+- Bump `pylint` to `4.0.5`
+  ([#4244](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4244))
+
 ### Breaking changes
 
 - Drop Python 3.9 support

CLAUDE.md

@@ -0,0 +1 @@
+@AGENTS.md

dev-requirements.txt

@@ -1,4 +1,4 @@
-pylint==3.0.2
+pylint==4.0.5
 httpretty==1.1.4
 pyright==v1.1.404
 sphinx==7.1.2

instrumentation-genai/opentelemetry-instrumentation-openai-agents-v2/src/opentelemetry/instrumentation/openai_agents/span_processor.py

@@ -426,6 +426,7 @@ def get_span_name(
 class GenAISemanticProcessor(TracingProcessor):
     """Trace processor adding GenAI semantic convention attributes with metrics."""
 
+    # pylint: disable=too-many-positional-arguments
     def __init__(
         self,
         tracer: Optional[Tracer] = None,

instrumentation/opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/__init__.py

@@ -586,7 +586,7 @@ class OpenTelemetryMiddleware:
         exclude_spans: Optionally exclude HTTP `send` and/or `receive` spans from the trace.
     """
 
-    # pylint: disable=too-many-branches
+    # pylint: disable=too-many-branches,too-many-positional-arguments
     def __init__(
         self,
         app,

instrumentation/opentelemetry-instrumentation-asyncio/tests/test_asyncio_run_coroutine_threadsafe.py

@@ -13,9 +13,7 @@
 # limitations under the License.
 import asyncio
 import threading
-from concurrent.futures import (  # pylint: disable=no-name-in-module; TODO #4199
-    ThreadPoolExecutor,
-)
+from concurrent.futures import ThreadPoolExecutor
 from unittest.mock import patch
 
 # pylint: disable=no-name-in-module

instrumentation/opentelemetry-instrumentation-botocore/tests/test_botocore_bedrock.py

@@ -1487,7 +1487,6 @@ def test_invoke_model_with_content(
         finish_reason = "length"
     else:
         pytest.xfail("model family not handled: {model_family}")
-        return
 
     assert_message_in_logs(logs[0], "gen_ai.user.message", user_content, span)
 
@@ -1628,7 +1627,6 @@ def test_invoke_model_with_content_different_events(
         choice_content = [{"type": "text", "text": "This is a test"}]
     else:
         pytest.xfail("llm_model_value not handled: {llm_model_value}")
-        return
 
     body = get_invoke_model_body(
         llm_model_value,
@@ -2070,7 +2068,6 @@ def test_invoke_model_with_content_tool_call(
         llm_model_config = AnthropicClaudeModel
     else:
         pytest.xfail("model family not handled: {model_family}")
-        return
 
     invoke_model_tool_call(
         span_exporter,
@@ -2156,7 +2153,6 @@ def test_invoke_model_no_content(
         finish_reason = "length"
     else:
         pytest.xfail("model family not handled: {model_family}")
-        return
 
     choice_body = {
         "index": 0,
@@ -2190,7 +2186,6 @@ def test_invoke_model_no_content_different_events(
         finish_reason = "end_turn"
     else:
         pytest.xfail("llm_model_value not handled: {llm_model_value}")
-        return
 
     body = get_invoke_model_body(
         llm_model_value,
@@ -2246,7 +2241,6 @@ def test_invoke_model_no_content_tool_call(
         llm_model_config = AnthropicClaudeModel
     else:
         pytest.xfail("model family not handled: {model_family}")
-        return
 
     invoke_model_tool_call(
         span_exporter,
@@ -2401,7 +2395,6 @@ def test_invoke_model_with_response_stream_with_content(
         }
     else:
         pytest.xfail("model family not handled: {model_family}")
-        return
 
     choice_body = {
         "index": 0,
@@ -2437,7 +2430,6 @@ def test_invoke_model_with_response_stream_with_content_different_events(
         choice_content = [{"text": "This is a test", "type": "text"}]
     else:
         pytest.xfail("llm_model_value not handled: {llm_model_value}")
-        return
 
     max_tokens = 10
     body = get_invoke_model_body(
@@ -2672,7 +2664,6 @@ def test_invoke_model_with_response_stream_with_content_tool_call(
         llm_model_config = AnthropicClaudeModel
     else:
         pytest.xfail("model family not handled: {model_family}")
-        return
 
     invoke_model_with_response_stream_tool_call(
         span_exporter,
@@ -2801,7 +2792,6 @@ def test_invoke_model_with_response_stream_no_content_different_events(
         finish_reason = "end_turn"
     else:
         pytest.xfail("llm_model_value not handled: {llm_model_value}")
-        return
 
     max_tokens = 10
     body = get_invoke_model_body(
@@ -2864,7 +2854,6 @@ def test_invoke_model_with_response_stream_no_content_tool_call(
         llm_model_config = AnthropicClaudeModel
     else:
         pytest.xfail("model family not handled: {model_family}")
-        return
 
     invoke_model_with_response_stream_tool_call(
         span_exporter,

instrumentation/opentelemetry-instrumentation-threading/tests/test_threading.py

@@ -15,7 +15,7 @@
 from __future__ import annotations
 
 import threading
-from concurrent.futures import (  # pylint: disable=no-name-in-module; TODO #4199
+from concurrent.futures import (
     Future,
     ThreadPoolExecutor,
 )