Reverting unnecessary changes and dealing with comments

Author: shuningc

util/opentelemetry-util-genai/CHANGELOG.md

@@ -22,10 +22,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   ([https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3891](#3891))
 - Add parent class genAI invocation
   ([https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3889](#3889))
-- Add `EmbeddingInvocation` span lifecycle support (`start_embedding`,
-  `stop_embedding`, `fail_embedding`), embedding span tests, and defer
-  embedding metrics emission (current no-op) to a follow-up PR.
-  ([#<PR_NUMBER>](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/<PR_NUMBER>))
+- Add EmbeddingInvocation span lifecycle support
+  ([https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4219](#4219))
 
 ## Version 0.2b0 (2025-10-14)
 
@@ -38,8 +36,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Make inputs / outputs / system instructions optional params to `on_completion`,
   ([https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3802](#3802)).
   - Use a SHA256 hash of the system instructions as it's upload filename, and check
-  if the file exists before re-uploading it, ([https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3814](#3814)).
-
+    if the file exists before re-uploading it, ([https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3814](#3814)).
 
 ## Version 0.1b0 (2025-09-25)
 
@@ -53,6 +50,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   ([#3752](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3752))
   ([#3759](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3759))
   ([#3763](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3763))
+
 - Add a utility to parse the `OTEL_INSTRUMENTATION_GENAI_CAPTURE_MESSAGE_CONTENT` environment variable.
   Add `gen_ai_latest_experimental` as a new value to the Sem Conv stability flag ([#3716](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3716)).
 

util/opentelemetry-util-genai/README.rst

@@ -43,7 +43,7 @@ For embedding invocations, common attributes include:
 - `gen_ai.provider.name`: Str(openai)
 - `gen_ai.operation.name`: Str(embeddings)
 - `gen_ai.request.model`: Str(text-embedding-3-small)
-- `gen_ai.embedding.dimension_count`: Int(1536)
+- `gen_ai.embeddings.dimension.count`: Int(1536)
 - `gen_ai.request.encoding_formats`: Slice(["float"])
 - `gen_ai.usage.input_tokens`: Int(24)
 - `server.address`: Str(api.openai.com)

util/opentelemetry-util-genai/pyproject.toml

@@ -25,8 +25,8 @@ classifiers = [
   "Programming Language :: Python :: 3.13",
 ]
 dependencies = [
-  "opentelemetry-instrumentation ~= 0.58b0",
-  "opentelemetry-semantic-conventions ~= 0.58b0",
+  "opentelemetry-instrumentation ~= 0.60b1",
+  "opentelemetry-semantic-conventions ~= 0.60b1",
   "opentelemetry-api>=1.31.0",
 ]
 
@@ -45,10 +45,7 @@ Repository = "https://github.com/open-telemetry/opentelemetry-python-contrib"
 path = "src/opentelemetry/util/genai/version.py"
 
 [tool.hatch.build.targets.sdist]
-include = [
-  "/src",
-  "/tests",
-]
+include = ["/src", "/tests"]
 
 [tool.hatch.build.targets.wheel]
 packages = ["src/opentelemetry"]

util/opentelemetry-util-genai/src/opentelemetry/util/genai/handler.py

@@ -234,9 +234,6 @@ def start_embedding(
             name=f"{invocation.operation_name} {invocation.request_model}",
             kind=SpanKind.CLIENT,
         )
-        # Record a monotonic start timestamp (seconds) for duration
-        # calculation using timeit.default_timer.
-        invocation.monotonic_start_s = timeit.default_timer()
         invocation.span = span
         invocation.context_token = otel_context.attach(
             set_span_in_context(span)

util/opentelemetry-util-genai/src/opentelemetry/util/genai/span_utils.py

@@ -32,10 +32,10 @@
 from opentelemetry.trace.propagation import set_span_in_context
 from opentelemetry.trace.status import Status, StatusCode
 from opentelemetry.util.genai.types import (
+    EmbeddingInvocation,
     Error,
     InputMessage,
     LLMInvocation,
-    EmbeddingInvocation,
     MessagePart,
     OutputMessage,
 )
@@ -217,44 +217,6 @@ def _maybe_emit_llm_event(
     logger.emit(event)
 
 
-def _maybe_emit_embedding_event(
-    logger: Logger | None,
-    span: Span,
-    invocation: EmbeddingInvocation,
-    error: Error | None = None,
-) -> None:
-    """Emit a gen_ai.client.inference.operation.details event to the logger.
-
-    This function creates a LogRecord event following the semantic convention
-    for gen_ai.client.inference.operation.details as specified in the GenAI
-    event semantic conventions.
-
-    For more details, see the semantic convention documentation:
-    https://github.com/open-telemetry/semantic-conventions/blob/main/docs/gen-ai/gen-ai-events.md#event-eventgen_aiclientinferenceoperationdetails
-    """
-    if not is_experimental_mode() or not should_emit_event() or logger is None:
-        return
-
-    # Build event attributes by reusing the attribute getter functions
-    attributes: dict[str, Any] = {}
-    attributes.update(_get_embedding_common_attributes(invocation))
-    attributes.update(_get_embedding_request_attributes(invocation))
-    attributes.update(_get_embedding_response_attributes(invocation))
-
-    # Add error.type if operation ended in error
-    if error is not None:
-        attributes[error_attributes.ERROR_TYPE] = error.type.__qualname__
-
-    # Create and emit the event
-    context = set_span_in_context(span, get_current())
-    event = LogRecord(
-        event_name="gen_ai.client.embedding.operation.details",
-        attributes=attributes,
-        context=context,
-    )
-    logger.emit(event)
-
-
 def _apply_llm_finish_attributes(
     span: Span, invocation: LLMInvocation
 ) -> None:
@@ -333,7 +295,7 @@ def _get_embedding_request_attributes(
     """Get GenAI request semantic convention attributes."""
     optional_attrs = (
         (GenAI.GEN_AI_REQUEST_MODEL, invocation.request_model),
-        (GenAI.GEN_AI_EMBEDDING_DIMENSION_COUNT, invocation.dimension_count),
+        (GenAI.GEN_AI_EMBEDDINGS_DIMENSION_COUNT, invocation.dimension_count),
         (GenAI.GEN_AI_REQUEST_ENCODING_FORMATS, invocation.encoding_formats),
     )
 
@@ -399,5 +361,4 @@ def _get_embedding_response_attributes(
     "_get_embedding_request_attributes",
     "_get_embedding_response_attributes",
     "_get_embedding_span_name",
-    "_maybe_emit_embedding_event",
 ]

util/opentelemetry-util-genai/tests/test_utils.py

@@ -973,7 +973,7 @@ def test_embedding_manual_start_and_stop_creates_span(self):
                 GenAI.GEN_AI_OPERATION_NAME: "embeddings",
                 GenAI.GEN_AI_REQUEST_MODEL: "embed-model",
                 GenAI.GEN_AI_PROVIDER_NAME: "test-provider",
-                GenAI.GEN_AI_EMBEDDING_DIMENSION_COUNT: 1536,
+                GenAI.GEN_AI_EMBEDDINGS_DIMENSION_COUNT: 1536,
                 GenAI.GEN_AI_REQUEST_ENCODING_FORMATS: ("float",),
                 GenAI.GEN_AI_USAGE_INPUT_TOKENS: 123,
                 server_attributes.SERVER_ADDRESS: "custom.server.com",