refactor: remove redundant pylint disable from celery instrumentation (#3839)

Author: forafox

.pylintrc

@@ -80,7 +80,8 @@ disable=missing-docstring,
       missing-module-docstring, # temp-pylint-upgrade
       import-error, # needed as a workaround as reported here: https://github.com/open-telemetry/opentelemetry-python-contrib/issues/290
       cyclic-import,
-      not-context-manager
+      not-context-manager,
+      attribute-defined-outside-init
 
 # Enable the message, report, category or checker with the given id(s). You can
 # either give multiple identifier separated by comma (,) or put this option

CHANGELOG.md

@@ -21,6 +21,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   ([#4335](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4335))
 - Expand `AGENTS.md` with instrumentation/GenAI guidance and add PR review instructions.
   ([#4457](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4457))
+- Remove redundant `pylint: disable=attribute-defined-outside-init` comments and add rule to global `.pylintrc` disable list
+  ([#3839](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3839))
 - `opentelemetry-exporter-richconsole`: Add support for suppressing resource information
   ([#3898](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3898))
 

instrumentation/opentelemetry-instrumentation-aiohttp-server/src/opentelemetry/instrumentation/aiohttp_server/__init__.py

@@ -550,7 +550,7 @@ def __init__(self, *args, **kwargs):
 
 
 class AioHttpServerInstrumentor(BaseInstrumentor):
-    # pylint: disable=protected-access,attribute-defined-outside-init
+    # pylint: disable=protected-access
     """An instrumentor for aiohttp.web.Application
 
     See `BaseInstrumentor`

instrumentation/opentelemetry-instrumentation-asyncio/src/opentelemetry/instrumentation/asyncio/__init__.py

@@ -120,7 +120,6 @@ def instrumentation_dependencies(self) -> Collection[str]:
         return _instruments
 
     def _instrument(self, **kwargs):
-        # pylint: disable=attribute-defined-outside-init
         self._tracer = get_tracer(
             __name__, __version__, kwargs.get("tracer_provider")
         )

instrumentation/opentelemetry-instrumentation-aws-lambda/src/opentelemetry/instrumentation/aws_lambda/__init__.py

@@ -465,9 +465,10 @@ def _instrument(self, **kwargs):
                 )
             )
             return
-        # pylint: disable=attribute-defined-outside-init
+
         # Convert slash-delimited paths to dot-delimited for valid Python imports
         lambda_handler = lambda_handler.replace("/", ".")
+
         (
             self._wrapped_module_name,
             self._wrapped_function_name,

instrumentation/opentelemetry-instrumentation-boto3sqs/src/opentelemetry/instrumentation/boto3sqs/__init__.py

@@ -82,7 +82,6 @@ def set(self, carrier: CarrierT, key: str, value: str) -> None:
 boto3sqs_setter = Boto3SQSSetter()
 
 
-# pylint: disable=attribute-defined-outside-init
 class Boto3SQSInstrumentor(BaseInstrumentor):
     received_messages_spans: Dict[str, Span] = {}
     current_span_related_to_token: Span = None
@@ -177,7 +176,7 @@ def _safe_end_processing_span(receipt_handle: str) -> None:
     @staticmethod
     def _extract_queue_name_from_url(queue_url: str) -> str:
         # A Queue name cannot have the `/` char, therefore we can return the part after the last /
-        return queue_url.split("/")[-1]
+        return queue_url.rsplit("/", maxsplit=1)[-1]
 
     def _create_processing_span(
         self,

instrumentation/opentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/__init__.py

@@ -140,6 +140,7 @@ def response_hook(span, service_name, operation_name, result):
     suppress_http_instrumentation,
     unwrap,
 )
+from opentelemetry.metrics import Instrument
 from opentelemetry.propagators.aws.aws_xray_propagator import (
     TRACE_HEADER_KEY,
     AwsXRayPropagator,
@@ -181,7 +182,15 @@ def instrumentation_dependencies(self) -> Collection[str]:
         return _instruments_botocore
 
     def _instrument(self, **kwargs):
-        # pylint: disable=attribute-defined-outside-init
+        # tracers are lazy initialized per-extension in _get_tracer
+        self._tracers = {}
+        # loggers are lazy initialized per-extension in _get_logger
+        self._loggers = {}
+        # meters are lazy initialized per-extension in _get_meter
+        self._meters = {}
+        # metrics are lazy initialized per-extension in _get_metrics
+        self._metrics: Dict[str, Dict[str, Instrument]] = {}
+
         self.request_hook = kwargs.get("request_hook")
         self.response_hook = kwargs.get("response_hook")
 

instrumentation/opentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/extensions/bedrock.py

@@ -460,7 +460,6 @@ def before_service_call(
                 span.update_name(f"{operation_name} {request_model}")
 
         # this is used to calculate the operation duration metric, duration may be skewed by request_hook
-        # pylint: disable=attribute-defined-outside-init
         self._operation_start = default_timer()
 
     # pylint: disable=no-self-use,too-many-locals

instrumentation/opentelemetry-instrumentation-celery/src/opentelemetry/instrumentation/celery/__init__.py

@@ -124,7 +124,6 @@ def instrumentation_dependencies(self) -> Collection[str]:
     def _instrument(self, **kwargs):
         tracer_provider = kwargs.get("tracer_provider")
 
-        # pylint: disable=attribute-defined-outside-init
         self._tracer = trace.get_tracer(
             __name__,
             __version__,

instrumentation/opentelemetry-instrumentation-confluent-kafka/src/opentelemetry/instrumentation/confluent_kafka/__init__.py

@@ -219,7 +219,6 @@ class ConfluentKafkaInstrumentor(BaseInstrumentor):
     See `BaseInstrumentor`
     """
 
-    # pylint: disable=attribute-defined-outside-init
     @staticmethod
     def instrument_producer(
         producer: Producer, tracer_provider=None