Removing embedding events emission

Author: shuningc

util/opentelemetry-util-genai/src/opentelemetry/util/genai/handler.py

@@ -85,7 +85,6 @@
     _apply_llm_finish_attributes,
     _get_embedding_span_name,
     _get_llm_span_name,
-    _maybe_emit_embedding_event,
     _maybe_emit_llm_event,
 )
 from opentelemetry.util.genai.types import (
@@ -181,7 +180,6 @@ def _stop(self, invocation: _T) -> _T:
             elif isinstance(invocation, EmbeddingInvocation):
                 _apply_embedding_finish_attributes(span, invocation)
                 self._record_metrics(invocation, span)
-                _maybe_emit_embedding_event(self._logger, span, invocation)
         finally:
             # Detach context and end span even if finishing fails
             otel_context.detach(invocation.context_token)
@@ -208,9 +206,6 @@ def _fail(self, invocation: _T, error: Error) -> _T:
                 _apply_embedding_finish_attributes(span, invocation)
                 _apply_error_attributes(span, error, error_type)
                 self._record_metrics(invocation, span, error_type=error_type)
-                _maybe_emit_embedding_event(
-                    self._logger, span, invocation, error_type
-                )
         finally:
             # Detach context and end span even if finishing fails
             otel_context.detach(invocation.context_token)

util/opentelemetry-util-genai/src/opentelemetry/util/genai/span_utils.py

@@ -227,44 +227,6 @@ def _maybe_emit_llm_event(
     logger.emit(event)
 
 
-def _maybe_emit_embedding_event(
-    logger: Logger | None,
-    span: Span,
-    invocation: EmbeddingInvocation,
-    error_type: str | None = None,
-) -> None:
-    """Emit a gen_ai.client.inference.operation.details event to the logger.
-
-    This function creates a LogRecord event following the semantic convention
-    for gen_ai.client.inference.operation.details as specified in the GenAI
-    event semantic conventions.
-
-    For more details, see the semantic convention documentation:
-    https://github.com/open-telemetry/semantic-conventions/blob/main/docs/gen-ai/gen-ai-events.md#event-eventgen_aiclientinferenceoperationdetails
-    """
-    if not is_experimental_mode() or not should_emit_event() or logger is None:
-        return
-
-    # Build event attributes by reusing the attribute getter functions
-    attributes: dict[str, Any] = {}
-    attributes.update(_get_embedding_common_attributes(invocation))
-    attributes.update(_get_embedding_request_attributes(invocation))
-    attributes.update(_get_embedding_response_attributes(invocation))
-
-    # Add error.type if operation ended in error
-    if error_type is not None:
-        attributes[error_attributes.ERROR_TYPE] = error_type
-
-    # Create and emit the event
-    context = set_span_in_context(span, get_current())
-    event = LogRecord(
-        event_name="gen_ai.client.embedding.operation.details",
-        attributes=attributes,
-        context=context,
-    )
-    logger.emit(event)
-
-
 def _apply_llm_finish_attributes(
     span: Span, invocation: LLMInvocation
 ) -> None:
@@ -403,7 +365,6 @@ def _get_embedding_response_attributes(
     "_get_llm_response_attributes",
     "_get_llm_span_name",
     "_maybe_emit_llm_event",
-    "_maybe_emit_embedding_event",
     "_apply_embedding_finish_attributes",
     "_get_embedding_common_attributes",
     "_get_embedding_request_attributes",