Feedback and style/lint updates

Author: keith-decker

util/opentelemetry-util-genai/src/opentelemetry/util/genai/handler.py

@@ -82,7 +82,6 @@
     get_tracer,
     set_span_in_context,
 )
-from opentelemetry.trace.status import Status, StatusCode
 from opentelemetry.util.genai.metrics import InvocationMetricsRecorder
 from opentelemetry.util.genai.span_utils import (
     _apply_embedding_finish_attributes,
@@ -261,7 +260,7 @@ def _fail(self, invocation: _T, error: Error) -> _T:
                 invocation.error_type = error_type
                 _finish_tool_call_span(span, invocation, capture_content=True)
                 self._record_metrics(invocation, span, error_type=error_type)
-                span.set_status(Status(StatusCode.ERROR, error.message))
+                _apply_error_attributes(span, error, error_type)
             elif isinstance(invocation, WorkflowInvocation):
                 _apply_workflow_finish_attributes(span, invocation)
                 _apply_error_attributes(span, error, error_type)

util/opentelemetry-util-genai/src/opentelemetry/util/genai/metrics.py

@@ -48,10 +48,9 @@ def record(
         # Build attributes based on invocation type
         attributes: Dict[str, AttributeValue] = {}
 
+        attributes[GenAI.GEN_AI_OPERATION_NAME] = invocation.operation_name
+
         if isinstance(invocation, LLMInvocation):
-            attributes[GenAI.GEN_AI_OPERATION_NAME] = (
-                GenAI.GenAiOperationNameValues.CHAT.value
-            )
             if invocation.request_model:
                 attributes[GenAI.GEN_AI_REQUEST_MODEL] = (
                     invocation.request_model
@@ -60,11 +59,6 @@ def record(
                 attributes[GenAI.GEN_AI_RESPONSE_MODEL] = (
                     invocation.response_model_name
                 )
-        else:
-            # ToolCall
-            attributes[GenAI.GEN_AI_OPERATION_NAME] = (
-                GenAI.GenAiOperationNameValues.EXECUTE_TOOL.value
-            )
 
         # Common attributes across invocation types
         if invocation.provider:

util/opentelemetry-util-genai/src/opentelemetry/util/genai/span_utils.py

@@ -402,9 +402,9 @@ def _get_embedding_response_attributes(
 def _get_tool_call_span_name(tool_call: ToolCall) -> str:
     """Get span name for tool call execution per semantic convention.
 
-    Format: "execute_tool {gen_ai.tool.name}"
+    Format: "{operation_name} {gen_ai.tool.name}"
     """
-    return f"{tool_call.operation_name} {tool_call.name}"
+    return f"{tool_call.operation_name} {tool_call.name}".strip()
 
 
 def _apply_tool_call_attributes(