GenAI Utils | fix lint

Author: etserend

util/opentelemetry-util-genai/CHANGELOG.md

@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+- Add `_BaseAgent` shared base class and `AgentCreation` type for agent creation lifecycle spans
+  ([#XXXX](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/XXXX))
 - Add support for emitting inference events and enrich message types. ([#3994](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3994))
 - Add support for `server.address`, `server.port` on all signals and additional metric-only attributes
   ([#4069](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4069))

util/opentelemetry-util-genai/src/opentelemetry/util/genai/handler.py

@@ -227,9 +227,7 @@ def start_create_agent(
         )
         creation.monotonic_start_s = timeit.default_timer()
         creation.span = span
-        creation.context_token = otel_context.attach(
-            set_span_in_context(span)
-        )
+        creation.context_token = otel_context.attach(set_span_in_context(span))
         return creation
 
     def stop_create_agent(self, creation: AgentCreation) -> AgentCreation:  # pylint: disable=no-self-use

util/opentelemetry-util-genai/src/opentelemetry/util/genai/span_utils.py

@@ -373,6 +373,10 @@ def _apply_creation_finish_attributes(
     "_get_llm_response_attributes",
     "_get_llm_span_name",
     "_maybe_emit_llm_event",
+    "_GEN_AI_AGENT_NAME",
+    "_GEN_AI_AGENT_ID",
+    "_GEN_AI_AGENT_DESCRIPTION",
+    "_GEN_AI_AGENT_VERSION",
     "_get_base_agent_common_attributes",
     "_get_base_agent_span_name",
     "_apply_creation_finish_attributes",

util/opentelemetry-util-genai/tests/test_handler_agent.py

@@ -10,7 +10,14 @@
 from opentelemetry.semconv._incubating.attributes import (
     gen_ai_attributes as GenAI,
 )
+from opentelemetry.trace import SpanKind
 from opentelemetry.util.genai.handler import TelemetryHandler
+from opentelemetry.util.genai.span_utils import (
+    _GEN_AI_AGENT_DESCRIPTION,
+    _GEN_AI_AGENT_ID,
+    _GEN_AI_AGENT_NAME,
+    _GEN_AI_AGENT_VERSION,
+)
 from opentelemetry.util.genai.types import (
     AgentCreation,
     Error,
@@ -48,9 +55,7 @@ def test_start_stop_create_agent(self) -> None:
         self.assertEqual(
             span.attributes[GenAI.GEN_AI_OPERATION_NAME], "create_agent"
         )
-        self.assertEqual(
-            span.attributes[GenAI.GEN_AI_AGENT_NAME], "New Agent"
-        )
+        self.assertEqual(span.attributes[_GEN_AI_AGENT_NAME], "New Agent")
 
     def test_create_agent_span_kind_is_client(self) -> None:
         handler = self._make_handler()
@@ -59,8 +64,6 @@ def test_create_agent_span_kind_is_client(self) -> None:
         handler.stop_create_agent(creation)
 
         spans = self.span_exporter.get_finished_spans()
-        from opentelemetry.trace import SpanKind
-
         self.assertEqual(spans[0].kind, SpanKind.CLIENT)
 
     def test_create_agent_with_all_base_attributes(self) -> None:
@@ -82,12 +85,10 @@ def test_create_agent_with_all_base_attributes(self) -> None:
         self.assertEqual(len(spans), 1)
         attrs = spans[0].attributes
         self.assertEqual(attrs[GenAI.GEN_AI_OPERATION_NAME], "create_agent")
-        self.assertEqual(attrs[GenAI.GEN_AI_AGENT_NAME], "Full Agent")
-        self.assertEqual(attrs[GenAI.GEN_AI_AGENT_ID], "agent-123")
-        self.assertEqual(
-            attrs[GenAI.GEN_AI_AGENT_DESCRIPTION], "A test agent"
-        )
-        self.assertEqual(attrs[GenAI.GEN_AI_AGENT_VERSION], "1.0.0")
+        self.assertEqual(attrs[_GEN_AI_AGENT_NAME], "Full Agent")
+        self.assertEqual(attrs[_GEN_AI_AGENT_ID], "agent-123")
+        self.assertEqual(attrs[_GEN_AI_AGENT_DESCRIPTION], "A test agent")
+        self.assertEqual(attrs[_GEN_AI_AGENT_VERSION], "1.0.0")
         self.assertEqual(attrs[GenAI.GEN_AI_PROVIDER_NAME], "openai")
         self.assertEqual(attrs[GenAI.GEN_AI_REQUEST_MODEL], "gpt-4")