bug(instrumentation-botocore): CI fails with aiohttp.streams AsyncStreamReaderMixin AttributeError

[MikeGoldsmith]

Summary

instrumentation-botocore-2 and instrumentation-botocore-3 CI jobs are deterministically failing with an import error inside vcrpy's aiohttp stubs. This is not flaky — every run fails with the same error.

The failure was first observed when cross-repo CI from opentelemetry-python merge queue runs hit it on PR open-telemetry/opentelemetry-python#5214 (a docstring-only change unrelated to botocore).

Error

.tox/py310-test-instrumentation-botocore-3/lib/python3.10/site-packages/vcr/stubs/aiohttp_stubs.py:21:
  from aiohttp import ClientConnectionError, ClientResponse, CookieJar, RequestInfo, hdrs, streams
E AttributeError: module 'aiohttp.streams' has no attribute 'AsyncStreamReaderMixin'

Root cause

A newer aiohttp version removed/renamed AsyncStreamReaderMixin in aiohttp.streams. The installed vcrpy version's aiohttp stubs still reference the old symbol, so the import fails at collection time and the whole test job errors out.

Affected jobs

• contrib / instrumentation-botocore-2
• contrib / instrumentation-botocore-3

Reproductions (failing core merge_group runs)

• https://github.com/open-telemetry/opentelemetry-python/actions/runs/26785601025
• https://github.com/open-telemetry/opentelemetry-python/actions/runs/26778296062
• https://github.com/open-telemetry/opentelemetry-python/actions/runs/26777774005

Impact

Blocks the core repo merge queue when contrib cross-repo tests run, since any PR that triggers contrib CI hits the same failure regardless of what the PR actually changed.

Suggested fix

In instrumentation/opentelemetry-instrumentation-botocore/, either:

1. Pin vcrpy to a version compatible with the current aiohttp, or
2. Constrain aiohttp to a version still compatible with the installed vcrpy, or
3. Bump vcrpy to a release that no longer references AsyncStreamReaderMixin.

Option 3 is preferred if available — keeps deps current.

[aabmass]

Seems to be blocking all merges right now. So we should either disable the test or pin the correct transitive deps for a quick fix

[DylanRussell]

We merged a quick fix (#4646) but option #3 sounds good

[popsiclelmlm]

I checked whether option 3 is available with currently released packages.

Results from fresh Python 3.13 virtualenvs:

# Current pytest-vcr dependency resolution with a new aiohttp
pip install 'aiohttp>=3.12' 'pytest-vcr==1.0.2'
python -c 'import aiohttp; print(aiohttp.__version__); import vcr.stubs.aiohttp_stubs'
# aiohttp 3.14.0
# AttributeError: module 'aiohttp.streams' has no attribute 'AsyncStreamReaderMixin'

# Latest released vcrpy explicitly pinned
pip install 'aiohttp==3.14.0' 'vcrpy==8.1.1'
python -c 'import aiohttp; print(aiohttp.__version__); import vcr.stubs.aiohttp_stubs'
# aiohttp 3.14.0
# AttributeError: module 'aiohttp.streams' has no attribute 'AsyncStreamReaderMixin'

# vcrpy upstream PR branch
pip install 'aiohttp==3.14.0' 'git+https://github.com/kevin1024/vcrpy.git@refs/pull/996/head'
python -c 'import aiohttp; print(aiohttp.__version__); import vcr.stubs.aiohttp_stubs'
# aiohttp 3.14.0
# import ok

So a released vcrpy version does not appear to make option 3 available yet. The upstream fix seems to be tracked in kevin1024/vcrpy#995 / kevin1024/vcrpy#996; once that lands and is released, this repo should be able to replace the temporary aiohttp pins from #4646 with a vcrpy constraint/bump.