refactor: remove redundant pylint disable from celery instrumentation by forafox · Pull Request #3839 · open-telemetry/opentelemetry-python-contrib

forafox · 2025-10-13T17:47:12Z

Description

This PR removes the redundant pylint: disable=attribute-defined-outside-init comment from the celery instrumentation and adds this rule to the global pylint disable list in .pylintrc.

The attribute-defined-outside-init pylint rule is problematic for OpenTelemetry instrumentations because attributes are commonly set during instrumentation (in methods like _instrument()) rather than in __init__. This pattern is used throughout the codebase (30+ occurrences) and is a standard practice for OpenTelemetry instrumentations where attributes are initialized during the instrumentation process.

By disabling this rule globally, we eliminate the need for individual pylint: disable comments across the codebase, making the code cleaner and more maintainable.

Fixes #3828

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Verified that the celery instrumentation file compiles without syntax errors
Confirmed that the pylint disable comment has been completely removed from celery instrumentation
Verified that attribute-defined-outside-init has been added to the global pylint disable list
Ran pylint checks to ensure no new warnings are introduced

Does This PR Require a Core Repo Change?

Yes. - Link to PR:
No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

Followed the style guidelines of this project
Changelogs have been updated
Unit tests have been added
Documentation has been updated

linux-foundation-easycla · 2025-10-13T17:47:19Z

The committers listed above are authorized under a signed CLA.

✅ login: aabmass / name: Aaron Abbott (663d041)
✅ login: forafox / name: Andrey (0f7004a, dbf91a4, dfab3bc, e16dd53, e53ef3b, f3073d6)
✅ login: forafox / name: Andrey Karabanov (5c14e7b, 7ba7c07, 9718af3, d681d37, dec395e, 33578d7, 985b02f, d09241a, e00110a)
✅ login: lzchen / name: Leighton Chen (12dad59, 351b52b)
✅ login: xrmx / name: Riccardo Magliocchetti (2b9d102)

xrmx

If we are going to move this globally I would expect the other 30 occurences of the pylint disable to move removed too. Said that the lint warning may be useful in other cases.

…ed-outside-init

…y-python-contrib into cleanup/remove-pylint-disable-celery

forafox · 2025-10-15T21:49:13Z

If we are going to move this globally I would expect the other 30 occurences of the pylint disable to move removed too. Said that the lint warning may be useful in other cases.

Pull request updated
@xrmx

tammy-baylis-swi · 2025-12-08T18:29:47Z

Please also do tox -e precommit on your local then push changes to address some formatting stuff.

forafox · 2025-12-09T07:37:16Z

Please also do tox -e precommit on your local then push changes to address some formatting stuff.

@tammy-baylis-swi

Hi! Thanks for the feedback — I’ve addressed the formatting issues
Everything should be fixed now

tammy-baylis-swi

Thanks, lgtm! Others will also review

tammy-baylis-swi · 2026-02-26T16:44:52Z

Please also add a Changelog entry.

github-actions · 2026-03-13T03:57:13Z

This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment.
If you're still working on this, please add a comment or push new commits.

… CHANGELOG entry

forafox · 2026-03-17T13:46:32Z

@tammy-baylis-swi Hi!
Everything should be fixed now

tammy-baylis-swi

Lgtm again, a Maintainer (not me) will have to merge. Please resolve the latest merge conflict.

…lery' into cleanup/remove-pylint-disable-celery

- Add missing `Instrument` import in botocore __init__.py - Fix PLC0207 string split in boto3sqs __init__.py

forafox · 2026-03-21T06:18:18Z

Lgtm again, a Maintainer (not me) will have to merge. Please resolve the latest merge conflict.
@tammy-baylis-swi
Everything should be fixed now

MikeGoldsmith

Thanks @forafox 🚀

github-actions · 2026-04-14T04:15:31Z

This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment.
If you're still working on this, please add a comment or push new commits.

github-actions · 2026-04-29T04:22:39Z

This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment.
If you're still working on this, please add a comment or push new commits.

refactor: remove redundant pylint disable from celery instrumentation

e00110a

forafox requested a review from a team as a code owner October 13, 2025 17:47

forafox closed this Oct 13, 2025

forafox reopened this Oct 13, 2025

forafox force-pushed the cleanup/remove-pylint-disable-celery branch from e00110a to d501764 Compare October 14, 2025 15:59

xrmx added this to Python PR digest Oct 15, 2025

xrmx moved this to Reviewed PRs that need fixes in Python PR digest Oct 15, 2025

xrmx reviewed Oct 15, 2025

View reviewed changes

cleanup: remove redundant pylint disable comments for attribute-defin…

985b02f

…ed-outside-init

forafox force-pushed the cleanup/remove-pylint-disable-celery branch from d501764 to 985b02f Compare October 15, 2025 21:43

forafox added 2 commits October 16, 2025 00:46

cleanup: remove redundant pylint disable comments for attribute-defin…

33578d7

…ed-outside-init

Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…

d09241a

…y-python-contrib into cleanup/remove-pylint-disable-celery

forafox requested a review from xrmx October 15, 2025 23:31

Merge branch 'main' into cleanup/remove-pylint-disable-celery

9718af3

forafox and others added 2 commits December 9, 2025 10:35

tests: format logging instrumentor fixtures

0f7004a

Merge branch 'main' into cleanup/remove-pylint-disable-celery

7ba7c07

tammy-baylis-swi approved these changes Dec 9, 2025

View reviewed changes

Merge branch 'main' into cleanup/remove-pylint-disable-celery

d681d37

xrmx moved this from Reviewed PRs that need fixes to Easy to review / merge / close in Python PR digest Dec 22, 2025

Merge branch 'main' into cleanup/remove-pylint-disable-celery

5c14e7b

MikeGoldsmith approved these changes Feb 25, 2026

View reviewed changes

MikeGoldsmith moved this from Easy to review / merge / close to Approved PRs that need fixes in Python PR digest Feb 27, 2026

github-actions Bot added the Stale label Mar 13, 2026

Merge branch 'main' into cleanup/remove-pylint-disable-celery and add…

e16dd53

… CHANGELOG entry

forafox requested a review from MikeGoldsmith March 17, 2026 13:45

Merge branch 'main' into cleanup/remove-pylint-disable-celery

dec395e

github-actions Bot removed the Stale label Mar 18, 2026

MikeGoldsmith approved these changes Mar 18, 2026

View reviewed changes

tammy-baylis-swi approved these changes Mar 20, 2026

View reviewed changes

forafox added 4 commits March 21, 2026 13:05

Merge upstream main into cleanup/remove-pylint-disable-celery

f3073d6

Merge remote-tracking branch 'origin/cleanup/remove-pylint-disable-ce…

dfab3bc

…lery' into cleanup/remove-pylint-disable-celery

fix: resolve ruff linting errors after merge

e53ef3b

- Add missing `Instrument` import in botocore __init__.py - Fix PLC0207 string split in boto3sqs __init__.py

fix: apply ruff format to botocore __init__.py

dbf91a4

forafox requested a review from tammy-baylis-swi March 21, 2026 06:18

MikeGoldsmith approved these changes Mar 30, 2026

View reviewed changes

tammy-baylis-swi approved these changes Mar 30, 2026

View reviewed changes

github-actions Bot added the Stale label Apr 14, 2026

tammy-baylis-swi moved this from Approved PRs that need fixes to Approved PRs in Python PR digest Apr 14, 2026

tammy-baylis-swi removed the Stale label Apr 14, 2026

github-actions Bot added the Stale label Apr 29, 2026

Merge branch 'main' into cleanup/remove-pylint-disable-celery

663d041

aabmass enabled auto-merge (squash) May 7, 2026 15:46

aabmass moved this from Approved PRs to Ready for merge in Python PR digest May 7, 2026

xrmx disabled auto-merge May 7, 2026 15:55

xrmx and others added 2 commits May 7, 2026 17:59

Update CHANGELOG.md

2b9d102

Merge branch 'main' into cleanup/remove-pylint-disable-celery

351b52b

lzchen enabled auto-merge (squash) May 7, 2026 17:22

Merge branch 'main' into cleanup/remove-pylint-disable-celery

12dad59

lzchen merged commit db84ba5 into open-telemetry:main May 7, 2026
753 checks passed

github-project-automation Bot moved this from Ready for merge to Done in Python PR digest May 7, 2026

Conversation

forafox commented Oct 13, 2025 • edited by xrmx Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Does This PR Require a Core Repo Change?

Checklist:

Uh oh!

linux-foundation-easycla Bot commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xrmx left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

forafox commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tammy-baylis-swi commented Dec 8, 2025

Uh oh!

forafox commented Dec 9, 2025

Uh oh!

tammy-baylis-swi left a comment

Choose a reason for hiding this comment

Uh oh!

tammy-baylis-swi commented Feb 26, 2026

Uh oh!

github-actions Bot commented Mar 13, 2026

Uh oh!

forafox commented Mar 17, 2026

Uh oh!

tammy-baylis-swi left a comment

Choose a reason for hiding this comment

Uh oh!

forafox commented Mar 21, 2026

Uh oh!

MikeGoldsmith left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 14, 2026

Uh oh!

github-actions Bot commented Apr 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

forafox commented Oct 13, 2025 •

edited by xrmx

Loading

linux-foundation-easycla Bot commented Oct 13, 2025 •

edited

Loading

xrmx left a comment •

edited

Loading

forafox commented Oct 15, 2025 •

edited

Loading