feat: add support for aiobotocore instrumentation by herin049 · Pull Request #4049 · open-telemetry/opentelemetry-python-contrib

herin049 · 2025-12-23T03:43:59Z

Description

Adds support for aiobotocore instrumentation, following the implementation approach outlined in issue #4048.

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Unit tests have been added.

Does This PR Require a Core Repo Change?

Yes. - Link to PR:
No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

Followed the style guidelines of this project
Changelogs have been updated
Unit tests have been added
Documentation has been updated

xrmx · 2025-12-31T14:50:10Z

@lukeina2z @yiyuan-he wdyt?

emdneto

I can imagine some ways to run tests separately for each package, but it requires some modifications to the tox.ini. In the way this is implemented, we need both packages installed to run tests

herin049 · 2026-02-28T19:30:27Z

I can imagine some ways to run tests separately for each package, but it requires some modifications to the tox.ini. In the way this is implemented, we need both packages installed to run tests

botocore is a dependency of aiobotocore so there will never be a scenario where just aiobotocore is installed. I can try to make it so that the tests can be ran with just botocore installed, skipping any aiobotocore related tests.

tammy-baylis-swi · 2026-03-02T18:09:01Z

Could we also please have quick updates to the README and readthedocs about what's supported

herin049 · 2026-03-06T21:09:21Z

Could we also please have quick updates to the README and readthedocs about what's supported

@tammy-baylis-swi Done!

tammy-baylis-swi

Thanks! Lgtm

… installed

xrmx

A bunch of nits but LGTM, thanks!

herin049 · 2026-03-17T17:47:05Z

A bunch of nits but LGTM, thanks!

@xrmx Addressed all the comments.

Automated update of OpenTelemetry dependencies. **Build Status:** ❌ [failure](https://github.com/aws-observability/aws-otel-python-instrumentation/actions/runs/27184408784) **Updated versions:** - [OpenTelemetry Python](https://github.com/open-telemetry/opentelemetry-python/releases/tag/v1.42.1): 1.42.1 - [OpenTelemetry Contrib](https://github.com/open-telemetry/opentelemetry-python-contrib/releases/tag/v0.63b1): 0.63b1 - [opentelemetry-sdk-extension-aws](https://pypi.org/project/opentelemetry-sdk-extension-aws/2.1.0/): 2.1.0 - [opentelemetry-propagator-aws-xray](https://pypi.org/project/opentelemetry-propagator-aws-xray/1.0.2/): 1.0.2 **Upstream releases with breaking changes:** Note: the mechanism to detect upstream breaking changes is not perfect. Be sure to check all new releases and understand if any additional changes need to be addressed. **opentelemetry-python-contrib:** - [Version 1.41.0/0.62b0](https://github.com/open-telemetry/opentelemetry-python-contrib/releases/tag/v0.62b0) *Description of changes:* - Drops the `opentelemetry-instrumentation-boto` runtime dependency (legacy boto2 instrumentation), removed entirely upstream in: open-telemetry/opentelemetry-python-contrib#4303 - Drops Python 3.9 support to match upstream's new minimum (Python ≥3.10): open-telemetry/opentelemetry-python#5076 (core) and open-telemetry/opentelemetry-python-contrib#4412 (contrib) - Switches `from importlib_metadata import version` to stdlib `from importlib.metadata import version` after upstream dropped the third-party `importlib-metadata` package from `opentelemetry-api`: open-telemetry/opentelemetry-python#3234 - Refactors the botocore patches (`_botocore_patches.py`) to use the new `ExtensionRegistry` API. Upstream split `_KNOWN_EXTENSIONS` into `_BOTOCORE_EXTENSIONS` + `_AIOBOTOCORE_EXTENSIONS`, removed `_find_extension`, and moved `_safe_invoke` to `opentelemetry.instrumentation.botocore.utils` as part of adding aiobotocore instrumentation: open-telemetry/opentelemetry-python-contrib#4049 - Removes the Starlette ASGI `suppress_http_instrumentation` patch (which the existing ADOT TODO already flagged) since the ASGI middleware now natively honors `suppress_http_instrumentation` upstream: open-telemetry/opentelemetry-python-contrib#4375 - Adapts the configurator tests to upstream's renamed `BaggageSpanProcessor._baggage_key_predicate` → `_predicates` (now a list of callables, after the constructor was reworked to accept either a single predicate or a sequence): open-telemetry/opentelemetry-python-contrib#4371 - Adapts `test_otlp_attribute_vs_body_types` to upstream's `_VALID_ANY_VALUE_TYPES` switching `typing.Mapping`/`typing.Sequence` to `collections.abc.Mapping`/`collections.abc.Sequence`: open-telemetry/opentelemetry-python#5133 - Bumps the mysqlclient contract-test pin from `2.2.4` to `2.2.8` and updates the matching `db.name` assertion. The 0.62b0 dbapi semantic-convention migration (open-telemetry/opentelemetry-python-contrib#4109) added an empty-string filter inside `_set_db_name`, which exposed a latent gap: mysqlclient < 2.2.7 didn't expose a Python-level `conn.db` attribute (added upstream in PyMySQL/mysqlclient#752, shipped in mysqlclient 2.2.7), so OTel's dbapi instrumentation defaulted `database` to `""` and the empty value used to land on the span unconditionally. After 0.62b0 the empty value is dropped, so the assertion `db.name == ""` now fails with "key not found". Bumping mysqlclient lets `conn.db` flow through as the actual database name (`testdb`) so the assertion becomes meaningful. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Steve Liu <liustve@amazon.com>

herin049 changed the title ~~feat: add support for aiobotocore instrumentation (WIP)~~ feat: add support for aiobotocore instrumentation Dec 25, 2025

herin049 requested a review from a team as a code owner December 25, 2025 06:48

xrmx reviewed Dec 31, 2025

View reviewed changes

xrmx added this to Python PR digest Dec 31, 2025

xrmx moved this to Ready for review in Python PR digest Dec 31, 2025

herin049 force-pushed the feat/aiobotocore-instrumentation branch 2 times, most recently from d32315b to d93357b Compare January 21, 2026 18:36

herin049 requested a review from xrmx January 21, 2026 18:41

emdneto reviewed Feb 26, 2026

View reviewed changes

Comment thread instrumentation/opentelemetry-instrumentation-botocore/test-requirements-1.txt Outdated

Comment thread ...rumentation/opentelemetry-instrumentation-botocore/tests/test_aiobotocore_instrumentation.py

tammy-baylis-swi reviewed Feb 26, 2026

View reviewed changes

Comment thread ...y-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/extensions/registry.py

emdneto reviewed Feb 26, 2026

View reviewed changes

herin049 force-pushed the feat/aiobotocore-instrumentation branch from d93357b to cd347e4 Compare February 28, 2026 22:21

herin049 requested review from emdneto and tammy-baylis-swi February 28, 2026 22:35

herin049 force-pushed the feat/aiobotocore-instrumentation branch from f80ec06 to 3f24703 Compare March 6, 2026 21:08

tammy-baylis-swi approved these changes Mar 6, 2026

View reviewed changes

herin049 added 10 commits March 12, 2026 21:56

initial implementation for aiobotocore instrumentation

3a82c11

fix failing tests

6e81cdf

add basic set of tests for aiobotocore instrumentation

8304c99

update CHANGELOG.md

819dc56

address comments and update tests to run with and without aiobotocore…

9b9bc13

… installed

update workflows and fix lock file

020ccf9

update tests

547bc6c

fix lint

5d66316

Update botocore documentation to include aiobotocore

adfc07c

update bootstrap_gen.py

c9fad47

update botocore instrumentation test deps

6602525

herin049 force-pushed the feat/aiobotocore-instrumentation branch from a123507 to 6602525 Compare March 13, 2026 02:15

update uv.lock

0e59835

xrmx approved these changes Mar 17, 2026

View reviewed changes

Comment thread ...pentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/__init__.py Outdated

Comment thread CHANGELOG.md Outdated

Comment thread instrumentation/opentelemetry-instrumentation-botocore/tests/test_botocore_instrumentation.py Outdated

xrmx moved this from Ready for review to Approved PRs that need fixes in Python PR digest Mar 17, 2026

fix CHANGELOG.md and remove unused variable in tests

26cf34c

herin049 moved this from Approved PRs that need fixes to Easy to review / merge / close in Python PR digest Mar 17, 2026

Merge branch 'main' into feat/aiobotocore-instrumentation

6882bcf

xrmx enabled auto-merge (squash) March 19, 2026 09:04

xrmx merged commit 6d3bbfb into open-telemetry:main Mar 19, 2026
860 checks passed

github-project-automation Bot moved this from Easy to review / merge / close to Done in Python PR digest Mar 19, 2026

vprivat-ads mentioned this pull request Apr 15, 2026

opentelemetry-instrumentation-botocore: add ability to instrument aiobotocore #4048

Closed

liustve mentioned this pull request Jun 16, 2026

Nightly dependency update: OpenTelemetry 1.42.1/0.63b1 aws-observability/aws-otel-python-instrumentation#762

Merged

Uh oh!

Conversation

herin049 commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Does This PR Require a Core Repo Change?

Checklist:

Uh oh!

xrmx commented Dec 31, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

emdneto left a comment

Choose a reason for hiding this comment

Uh oh!

herin049 commented Feb 28, 2026

Uh oh!

tammy-baylis-swi commented Mar 2, 2026

Uh oh!

herin049 commented Mar 6, 2026

Uh oh!

tammy-baylis-swi left a comment

Choose a reason for hiding this comment

Uh oh!

xrmx left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

herin049 commented Mar 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

herin049 commented Dec 23, 2025 •

edited

Loading