Skip to content

Try out basedpyright with baseline file#4195

Draft
aabmass wants to merge 1 commit into
open-telemetry:mainfrom
aabmass:push-tlmxkvxpylln
Draft

Try out basedpyright with baseline file#4195
aabmass wants to merge 1 commit into
open-telemetry:mainfrom
aabmass:push-tlmxkvxpylln

Conversation

@aabmass

@aabmass aabmass commented Feb 13, 2026

Copy link
Copy Markdown
Member

Enables typechecking on python packages, examples, tests in the repo using basedpyright's baseline feature https://docs.basedpyright.com/latest/benefits-over-pyright/baseline/

Downsides to this approach:

Benefit:

  • All new code even in existing files will be forced to type check
  • Don't litter codebase with # type: ignore

Comment thread tox.ini
Comment on lines 1105 to 1115
@@ -1115,4 +1115,4 @@ deps =
{toxinidir}/instrumentation/opentelemetry-instrumentation-aiohttp-client[instruments]

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine many errors could be removed by adding all new instrumentations here too.

@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment.
If you're still working on this, please add a comment or push new commits.

@github-actions github-actions Bot added the Stale label Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant