Skip to content

[openai-agents] Populate instructions and tool definitions from Response obj#4196

Merged
lzchen merged 4 commits into
open-telemetry:mainfrom
adammw:adammw/openai-agents-response
Mar 11, 2026
Merged

[openai-agents] Populate instructions and tool definitions from Response obj#4196
lzchen merged 4 commits into
open-telemetry:mainfrom
adammw:adammw/openai-agents-response

Conversation

@adammw

@adammw adammw commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

Description

Populate system instructions and tool definitions attributes from Response obj

Fixes #4188

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Updated test_tracer.py with mocked unit tests
  • Manually tested with OpenAI Agents SDK sample code, confirmed attributes present

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@adammw adammw marked this pull request as ready for review February 16, 2026 04:57
@adammw adammw requested a review from a team as a code owner February 16, 2026 04:57
@tammy-baylis-swi

Copy link
Copy Markdown
Contributor

Thanks for contributing!

I think the agent tests for oldest should still pass (tox -e py3*-test-instrumentation-openai_agents-v2-oldest for each Python version); please take a look.

Please also do tox -e precommit to address formating-etc issues.

@adammw adammw force-pushed the adammw/openai-agents-response branch 2 times, most recently from 1790a79 to 013c6fa Compare February 18, 2026 02:30
@adammw adammw force-pushed the adammw/openai-agents-response branch from 013c6fa to c0d8909 Compare February 18, 2026 02:31
@adammw

adammw commented Feb 18, 2026

Copy link
Copy Markdown
Contributor Author

PR Updated

@tammy-baylis-swi

Copy link
Copy Markdown
Contributor

Great thanks! Another housekeeping: please could you update CHANGELOG.md with this PR url?

@tammy-baylis-swi tammy-baylis-swi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! This lgtm though I haven't worked on this particular instrumentor much. The Maintainers will have to review anyway.

@lzchen lzchen merged commit b44ca58 into open-telemetry:main Mar 11, 2026
784 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for review to Done in Python PR digest Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[OpenAI Agents] System prompt/instructions do not show in trace

8 participants