Fix pylint false positives for ThreadPoolExecutor

.pylintrc

@@ -39,7 +39,7 @@ persistent=yes
 
 # When enabled, pylint would attempt to guess common misconfiguration and emit
 # user-friendly hints instead of false-positive error messages.
-suggestion-mode=yes
+
 
 # Allow loading of arbitrary C extensions. Extensions are imported into the
 # active Python interpreter and may run arbitrary code.
@@ -463,6 +463,9 @@ valid-metaclass-classmethod-first-arg=cls
 # Maximum number of arguments for function / method.
 max-args=5
 
+# Maximum number of positional arguments for function / method.
+max-positional-arguments=10
+
 # Maximum number of attributes for a class (see R0902).
 max-attributes=7
 

CHANGELOG.md

@@ -86,7 +86,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   ([#4220](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4220))
 
 ### Fixed
-
+- Bump `pylint` to `4.0.5` to fix false-positive `no-name-in-module` errors for `concurrent.futures` imports on Python 3.14, and remove deprecated `suggestion-mode` option from `.pylintrc`.
+  ([#4244](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4244))
 - `opentelemetry-instrumentation-flask`: Align `http.server.active_requests` initialization with semantic convention helpers to ensure consistent names, units, and descriptions.
   ([#4094](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4094))
 - `opentelemetry-instrumentation-asyncio`: Fix environment variables not appearing in Read the Docs documentation

dev-requirements.txt

@@ -1,4 +1,4 @@
-pylint==3.0.2
+pylint==4.0.5
 httpretty==1.1.4
 pyright==v1.1.404
 sphinx==7.1.2

instrumentation/opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/__init__.py

@@ -583,7 +583,7 @@ class OpenTelemetryMiddleware:
         exclude_spans: Optionally exclude HTTP `send` and/or `receive` spans from the trace.
     """
 
-    # pylint: disable=too-many-branches
+    # pylint: disable=too-many-branches,too-many-positional-arguments
     def __init__(
         self,
         app,

instrumentation/opentelemetry-instrumentation-asyncio/tests/test_asyncio_run_coroutine_threadsafe.py

@@ -13,9 +13,7 @@
 # limitations under the License.
 import asyncio
 import threading
-from concurrent.futures import (  # pylint: disable=no-name-in-module; TODO #4199
-    ThreadPoolExecutor,
-)
+from concurrent.futures import ThreadPoolExecutor
 from unittest.mock import patch
 
 # pylint: disable=no-name-in-module

instrumentation/opentelemetry-instrumentation-botocore/tests/bedrock_utils.py

@@ -210,6 +210,7 @@ def assert_equal_or_not_present(value, attribute_name, span):
         assert attribute_name not in span.attributes, attribute_name
 
 
+# pylint: disable=too-many-positional-arguments
 def assert_all_attributes(
     span: ReadableSpan,
     request_model: str,

instrumentation/opentelemetry-instrumentation-dbapi/src/opentelemetry/instrumentation/dbapi/__init__.py

@@ -259,6 +259,7 @@ def trace_integration(
     )
 
 
+# pylint: disable=too-many-positional-arguments
 def wrap_connect(
     name: str,
     connect_module: Callable[..., Any],
@@ -339,6 +340,7 @@ def unwrap_connect(
     unwrap(connect_module, connect_method_name)
 
 
+# pylint: disable=too-many-positional-arguments
 def instrument_connection(
     name: str,
     connection: ConnectionT | TracedConnectionProxy[ConnectionT],
@@ -420,6 +422,7 @@ def uninstrument_connection(
 
 
 class DatabaseApiIntegration:
+    # pylint: disable=too-many-positional-arguments
     def __init__(
         self,
         name: str,

instrumentation/opentelemetry-instrumentation-fastapi/src/opentelemetry/instrumentation/fastapi/__init__.py

@@ -244,7 +244,7 @@ def instrument_app(
         http_capture_headers_server_response: list[str] | None = None,
         http_capture_headers_sanitize_fields: list[str] | None = None,
         exclude_spans: list[Literal["receive", "send"]] | None = None,
-    ):  # pylint: disable=too-many-locals
+    ):  # pylint: disable=too-many-locals,too-many-positional-arguments
         """Instrument an uninstrumented FastAPI application.
 
         Args:

instrumentation/opentelemetry-instrumentation-httpx/src/opentelemetry/instrumentation/httpx/__init__.py

@@ -1220,7 +1220,7 @@ def _uninstrument(self, **kwargs: typing.Any):
         unwrap(httpx.AsyncHTTPTransport, "handle_async_request")
 
     @staticmethod
-    def _handle_request_wrapper(  # pylint: disable=too-many-locals
+    def _handle_request_wrapper(  # pylint: disable=too-many-locals,too-many-positional-arguments
         wrapped: typing.Callable[..., typing.Any],
         instance: httpx.HTTPTransport,
         args: tuple[typing.Any, ...],
@@ -1351,7 +1351,7 @@ def _handle_request_wrapper(  # pylint: disable=too-many-locals
         return response
 
     @staticmethod
-    async def _handle_async_request_wrapper(  # pylint: disable=too-many-locals
+    async def _handle_async_request_wrapper(  # pylint: disable=too-many-locals,too-many-positional-arguments
         wrapped: typing.Callable[..., typing.Awaitable[typing.Any]],
         instance: httpx.AsyncHTTPTransport,
         args: tuple[typing.Any, ...],

instrumentation/opentelemetry-instrumentation-threading/tests/test_threading.py

@@ -15,7 +15,7 @@
 from __future__ import annotations
 
 import threading
-from concurrent.futures import (  # pylint: disable=no-name-in-module; TODO #4199
+from concurrent.futures import (
     Future,
     ThreadPoolExecutor,
 )

instrumentation/opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/client.py

@@ -59,7 +59,7 @@ def _normalize_request(args, kwargs):
     return (new_args, new_kwargs)
 
 
-def fetch_async(  # pylint: disable=too-many-locals
+def fetch_async(  # pylint: disable=too-many-locals,too-many-positional-arguments
     tracer,
     request_hook,
     response_hook,

instrumentation/opentelemetry-instrumentation-urllib3/src/opentelemetry/instrumentation/urllib3/__init__.py

@@ -424,7 +424,7 @@ def _get_span_name(method: str) -> str:
     return method
 
 
-# pylint: disable=too-many-locals
+# pylint: disable=too-many-locals,too-many-positional-arguments
 def _instrument(
     tracer: Tracer,
     duration_histogram_old: Histogram,
@@ -687,6 +687,7 @@ def _filter_attributes_semconv(
     return (duration_attrs_old, duration_attrs_new)
 
 
+# pylint: disable=too-many-positional-arguments
 def _record_metrics(
     metric_attributes: dict,
     duration_histogram_old: Histogram,

sdk-extension/opentelemetry-sdk-extension-aws/src/opentelemetry/sdk/extension/aws/trace/sampler/_sampling_rule.py

@@ -20,7 +20,7 @@
 
 
 # Disable snake_case naming style so this class can match the sampling rules response from X-Ray
-# pylint: disable=invalid-name
+# pylint: disable=invalid-name,too-many-positional-arguments
 class _SamplingRule:
     def __init__(
         self,

util/opentelemetry-util-genai/src/opentelemetry/util/genai/_upload/completion_hook.py

@@ -22,7 +22,7 @@
 import posixpath
 import threading
 from collections import OrderedDict
-from concurrent.futures import (  # pylint: disable=no-name-in-module; TODO #4199
+from concurrent.futures import (
     Future,
     ThreadPoolExecutor,
 )