Add Structlog Processor as Instrumentation#4286
Conversation
e0317fa to
fab1022
Compare
|
Thank you for undertaking this! |
fd07c37 to
ddae8b5
Compare
|
I think a rebase is needed. This PR is now reverting some unrelated docker-test fixes (this other PR) |
ef6ad9a to
ece1f64
Compare
Believe I went ahead and rebased, but feel free to let me know if it still looks off! |
|
Hey team, |
2648150 to
26c68f5
Compare
pmcollins
left a comment
There was a problem hiding this comment.
Hey Josh, this instrumentation seems to work fine, but I added some comments.
|
This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment. |
|
commenting |
|
Thanks for the PR! Just a heads-up: we no longer update Please add the appropriate changelog fragment for this change instead of editing |
|
This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment. |
4c55894 to
d3ac0a4
Compare
# Conflicts: # .github/workflows/test_1.yml # .github/workflows/test_2.yml # .github/workflows/test_3.yml
f9e1186 to
e4849da
Compare
Head branch was pushed to by a user without write access
|
Hi @xrmx, |
Puzzled by this since CI did run fine on main, anyway checked that |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes open-telemetry/opentelemetry-python#2993
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.