Skip to content

Add Structlog Processor as Instrumentation#4286

Merged
xrmx merged 23 commits into
open-telemetry:mainfrom
JWinermaSplunk:structlog-handler
Jul 3, 2026
Merged

Add Structlog Processor as Instrumentation#4286
xrmx merged 23 commits into
open-telemetry:mainfrom
JWinermaSplunk:structlog-handler

Conversation

@JWinermaSplunk

@JWinermaSplunk JWinermaSplunk commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes open-telemetry/opentelemetry-python#2993

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • test_structlog.py

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@JWinermaSplunk JWinermaSplunk marked this pull request as ready for review March 13, 2026 17:14
@JWinermaSplunk JWinermaSplunk requested a review from a team as a code owner March 13, 2026 17:14
@JWinermaSplunk JWinermaSplunk changed the title [WIP] Add Structlog Handler as Instrumentation Add Structlog Handler as Instrumentation Mar 13, 2026
@tammy-baylis-swi

Copy link
Copy Markdown
Contributor

Thank you for undertaking this!

Comment thread opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap_gen.py Outdated
@xrmx xrmx moved this to Reviewed PRs that need fixes in Python PR digest Mar 25, 2026
@tammy-baylis-swi

Copy link
Copy Markdown
Contributor

I think a rebase is needed. This PR is now reverting some unrelated docker-test fixes (this other PR)

@JWinermaSplunk

Copy link
Copy Markdown
Contributor Author

I think a rebase is needed. This PR is now reverting some unrelated docker-test fixes (this other PR)

Believe I went ahead and rebased, but feel free to let me know if it still looks off!

Comment thread CHANGELOG.md Outdated
@dodofarm

Copy link
Copy Markdown

Hey team,
any timeline on this PR? This is a great addition that we've been anticipating for quite some time!

@pmcollins pmcollins left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Josh, this instrumentation seems to work fine, but I added some comments.

@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment.
If you're still working on this, please add a comment or push new commits.

@github-actions github-actions Bot added the Stale label May 7, 2026
@JWinermaSplunk

Copy link
Copy Markdown
Contributor Author

commenting

@github-actions github-actions Bot removed the Stale label May 8, 2026
@emdneto

emdneto commented May 12, 2026

Copy link
Copy Markdown
Member

Thanks for the PR!

Just a heads-up: we no longer update CHANGELOG.md directly. The changelog is now generated from changelog fragments using Towncrier.

Please add the appropriate changelog fragment for this change instead of editing CHANGELOG.md manually. You can find the instructions and expected format in CONTRIBUTING.md.

@github-actions

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment.
If you're still working on this, please add a comment or push new commits.

@github-actions github-actions Bot added the Stale label May 27, 2026
@JWinermaSplunk JWinermaSplunk changed the title Add Structlog Handler as Instrumentation Add Structlog Processor as Instrumentation May 28, 2026
@xrmx xrmx enabled auto-merge July 2, 2026 15:51
auto-merge was automatically disabled July 2, 2026 18:01

Head branch was pushed to by a user without write access

@JWinermaSplunk

Copy link
Copy Markdown
Contributor Author

Hi @xrmx,
Precommit was failing on merge from master, so I went ahead and reran and pushed. Should be good to go now.
Thank you!

@xrmx

xrmx commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Hi @xrmx, Precommit was failing on merge from master, so I went ahead and reran and pushed. Should be good to go now. Thank you!

Puzzled by this since CI did run fine on main, anyway checked that tox -e precommit gives the very same result as yours. Thanks!

@xrmx xrmx added this pull request to the merge queue Jul 3, 2026
Merged via the queue into open-telemetry:main with commit 04a4953 Jul 3, 2026
761 checks passed
@github-project-automation github-project-automation Bot moved this from Approved PRs to Done in Python PR digest Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add handler for structlog

7 participants