Skip to content

opentelemetry-opamp-client: rename Callbacks to OpAMPCallbacks#4355

Merged
lzchen merged 3 commits into
open-telemetry:mainfrom
xrmx:opamp-rename-callbacks
Mar 24, 2026
Merged

opentelemetry-opamp-client: rename Callbacks to OpAMPCallbacks#4355
lzchen merged 3 commits into
open-telemetry:mainfrom
xrmx:opamp-rename-callbacks

Conversation

@xrmx

@xrmx xrmx commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Description

All the main classes have the OpAMP prefix, Callbacks is generic enough to have the prefix as well. Let's fix this now that we are in the early days.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx requested a review from a team as a code owner March 24, 2026 10:40
@xrmx xrmx moved this to Easy to review / merge / close in Python PR digest Mar 24, 2026

@pmcollins pmcollins left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lzchen lzchen merged commit 7747dca into open-telemetry:main Mar 24, 2026
860 checks passed
@github-project-automation github-project-automation Bot moved this from Easy to review / merge / close to Done in Python PR digest Mar 24, 2026
wrisa pushed a commit to wrisa/opentelemetry-python-contrib that referenced this pull request Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants