Skip to content

fix: map Python CRITICAL log level to OTel FATAL severity text #4365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xrmx merged 5 commits into from
Apr 1, 2026
+12 −6
Merged

fix: map Python CRITICAL log level to OTel FATAL severity text #4365

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
340d1e0
fix: map Python CRITICAL log level to OTel FATAL severity text in con…
Krishnachaitanyakc Mar 26, 2026
f5b0ac5
Merge branch 'main' into fix/map-critical-severity-text-to-fatal
lzchen Mar 26, 2026
dd470cf
Add CHANGELOG entry for CRITICAL -> FATAL severity text mapping
Krishnachaitanyakc Mar 26, 2026
7ceffe6
Update instrumentation/opentelemetry-instrumentation-logging/src/open…
xrmx Apr 1, 2026
8df47fd
Merge branch 'main' into fix/map-critical-severity-text-to-fatal
xrmx Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions ...pentelemetry-instrumentation-logging/src/opentelemetry/instrumentation/logging/handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,10 +188,16 @@ def _translate(self, record: logging.LogRecord) -> LogRecord:
else:
body = record.getMessage()

# related to https://github.com/open-telemetry/opentelemetry-python/issues/3548
# Severity Text = WARN as defined in https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/data-model.md#displaying-severity.
level_name = (
"WARN" if record.levelname == "WARNING" else record.levelname
# Map Python log level names to OTel severity text as defined in
# https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/data-model.md#displaying-severity
# Python "WARNING" -> OTel "WARN" (see open-telemetry/opentelemetry-python#3548)
# Python "CRITICAL" -> OTel "FATAL" (see open-telemetry/opentelemetry-python#4984)
Comment thread
xrmx marked this conversation as resolved.
Outdated
_python_to_otel_severity_text = {
Comment thread
Krishnachaitanyakc marked this conversation as resolved.
"WARNING": "WARN",
"CRITICAL": "FATAL",
}
level_name = _python_to_otel_severity_text.get(
record.levelname, record.levelname
)

return LogRecord(
Expand Down
4 changes: 2 additions & 2 deletions instrumentation/opentelemetry-instrumentation-logging/tests/test_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ def test_log_record_trace_correlation(self):
record.log_record.body,
"Critical message within span",
)
self.assertEqual(record.log_record.severity_text, "CRITICAL")
self.assertEqual(record.log_record.severity_text, "FATAL")
self.assertEqual(
record.log_record.severity_number,
SeverityNumber.FATAL,
Expand Down Expand Up @@ -390,7 +390,7 @@ def test_log_record_trace_correlation_deprecated(self):
self.assertEqual(
record.log_record.body, "Critical message within span"
)
self.assertEqual(record.log_record.severity_text, "CRITICAL")
self.assertEqual(record.log_record.severity_text, "FATAL")
self.assertEqual(
record.log_record.severity_number, SeverityNumber.FATAL
)
Expand Down
Loading