Always use LogRecord.getMessage to get the log body

[pR0Ps]

Description

This change makes the log exporting always call LogRecord.getMessage() in order to format and return the record's body text. This is a port of open-telemetry/opentelemetry-python#4327 to this new repo. See that pull request for more details and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I've updated and run the unit tests, as well as run manual tests of the functionality (see open-telemetry/opentelemetry-python#4216 for details)

Does This PR Require a Core Repo Change?

• No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

• Followed the style guidelines of this project
• Changelogs have been updated
• Unit tests have been added
• Documentation has been updated

[pmcollins]

Thanks for doing this. I'm in favor of this change, but because it's breaking, it probably warrants a discussion in the weekly SIG meeting. @pR0Ps not sure if you attend these already, but you are welcome to join if you are interested.

[MikeGoldsmith]

Changes look good. I agree with @pmcollins the changelog needs to indicate this is a breaking change.

PS the description references the core PR (#4327) for context, but that PR itself links to additional background that's useful for reviewers:

• open-telemetry/opentelemetry-python#4216 — the original issue and discussion that motivated this change
• open-telemetry/opentelemetry-python#3343 — the PR this is mostly reverting

Probably worth adding those directly to the description here so reviewers don't have to chase the chain 😄

[MikeGoldsmith]

Has this been discussed at a SIG call? I agree this probably the right thing to do, but would like other @open-telemetry/python-approvers to give input as it's a breaking change.

[pmcollins]

Has this been discussed at a SIG call? I agree this probably the right thing to do, but would like other @open-telemetry/python-approvers to give input as it's a breaking change.

Hey @MikeGoldsmith, ran out of time last week, but hope to discuss tomorrow.

[pmcollins]

Hi -- discussed this in the SIG meeting and folks seem to be in favor of this change. The fact that it has been moved out of the SDK give us some additional flexibility. Added a suggestion about the changelog entry.

[github-actions]

This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment.
If you're still working on this, please add a comment or push new commits.

[pR0Ps]

Not stale. @MikeGoldsmith @pmcollins anything else I need to do for this?

[aabmass]

Sorry for the delay, thanks for contributing