-
Notifications
You must be signed in to change notification settings - Fork 922
feat(asyncpg): add capture_connection_cleanup option to silence pool cleanup spans #4373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RiyaChaturvedi37
wants to merge
13
commits into
open-telemetry:main
Choose a base branch
from
RiyaChaturvedi37:fix/asyncpg-silence-cleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
73f9258
feat(asyncpg): add capture_connection_cleanup option to silence pool …
RiyaChaturvedi37 c6a7702
fix: remove trailing whitespace from blank lines
RiyaChaturvedi37 d2c7ef7
fix: remove trailing whitespace and fix line endings
RiyaChaturvedi37 7ea55a3
fix: apply ruff formatting
RiyaChaturvedi37 b2e6ea8
fix: uninstrument after test to avoid state leakage
RiyaChaturvedi37 4c08069
fix: address reviewer feedback - add tests, docs and fix changelog
RiyaChaturvedi37 9c92064
docs: clarify capture_connection_cleanup usage in docstring
RiyaChaturvedi37 5c46842
Merge branch 'main' into fix/asyncpg-silence-cleanup
RiyaChaturvedi37 8085072
fix: resolve CHANGELOG.md conflict
RiyaChaturvedi37 bf3e817
Merge branch 'main' into fix/asyncpg-silence-cleanup
RiyaChaturvedi37 8646854
refactor(asyncpg): replace capture_connection_cleanup with exclude_qu…
RiyaChaturvedi37 a9e4c28
Merge branch 'main' into fix/asyncpg-silence-cleanup
RiyaChaturvedi37 e0b7918
fix: fix inconsistent return statements in _is_excluded_query
RiyaChaturvedi37 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tammy-baylis-swi marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.