fix: _set_status should not override existing span status (#3713)#4410
Open
RiyaChaturvedi37 wants to merge 8 commits intoopen-telemetry:mainfrom
Open
fix: _set_status should not override existing span status (#3713)#4410RiyaChaturvedi37 wants to merge 8 commits intoopen-telemetry:mainfrom
RiyaChaturvedi37 wants to merge 8 commits intoopen-telemetry:mainfrom
Conversation
3ae80cc to
d712f06
Compare
xrmx
reviewed
Apr 10, 2026
239f47f to
7214d29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3713
Problem
_set_statuswas unconditionally callingspan.set_status(Status(status))without checking if a status was already set. This caused two bugs:
Fix
Added a priority check before calling
span.set_status:Tests
Added 4 new tests in
test_semconv_status.py: