Skip to content

maint: Add ci workflow to check links#4432

Merged
xrmx merged 7 commits intoopen-telemetry:mainfrom
apatniv:add_link_verifier
Apr 16, 2026
Merged

maint: Add ci workflow to check links#4432
xrmx merged 7 commits intoopen-telemetry:mainfrom
apatniv:add_link_verifier

Conversation

@apatniv
Copy link
Copy Markdown
Contributor

@apatniv apatniv commented Apr 14, 2026

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)
Address issue #1514

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

It is more accurate to test this on github workflow as this is where link validation checks would run.

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@apatniv apatniv requested a review from a team as a code owner April 14, 2026 13:21
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Apr 14, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

Comment thread .github/workflows/check-links.yaml Outdated
@tammy-baylis-swi tammy-baylis-swi moved this to Reviewed PRs that need fixes in Python PR digest Apr 14, 2026
@tammy-baylis-swi tammy-baylis-swi requested a review from a team April 14, 2026 23:15
@apatniv apatniv force-pushed the add_link_verifier branch from 26cd626 to f24f44c Compare April 15, 2026 03:19
@MikeGoldsmith MikeGoldsmith changed the title Add ci workflow to check links maint: Add ci workflow to check links Apr 15, 2026
Copy link
Copy Markdown
Member

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks @apatniv.

Comment thread .github/workflows/check-links.yml
@MikeGoldsmith MikeGoldsmith added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 15, 2026
Copy link
Copy Markdown
Contributor

@tammy-baylis-swi tammy-baylis-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, maybe add .rst as Mike has suggested.

@apatniv
Copy link
Copy Markdown
Contributor Author

apatniv commented Apr 15, 2026

@tammy-baylis-swi
Copy link
Copy Markdown
Contributor

@tammy-baylis-swi Do you want me to make a PR to add .rst to core repo's workflow: https://github.com/open-telemetry/opentelemetry-python/blob/9c48362c1d29acc74c333354c2c314bd3b71ef8e/.github/workflows/check-links.yml as well.

Sure @apatniv ! Much appreciated.

Comment thread .github/workflows/check-links.yml Outdated
Comment thread .github/workflows/check-links.yml Outdated
@github-project-automation github-project-automation bot moved this from Reviewed PRs that need fixes to Approved PRs in Python PR digest Apr 16, 2026
@apatniv
Copy link
Copy Markdown
Contributor Author

apatniv commented Apr 16, 2026

@tammy-baylis-swi Created a PR for core repo as well.
open-telemetry/opentelemetry-python#5114

@xrmx xrmx merged commit 498b928 into open-telemetry:main Apr 16, 2026
751 checks passed
@github-project-automation github-project-automation bot moved this from Approved PRs to Done in Python PR digest Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants