fix(instrumentation): add OTEL_SEMCONV_STABILITY_OPT_IN to CLI args#4438
fix(instrumentation): add OTEL_SEMCONV_STABILITY_OPT_IN to CLI args#4438alliasgher wants to merge 5 commits intoopen-telemetry:mainfrom
Conversation
MikeGoldsmith
left a comment
MikeGoldsmith
left a comment
There was a problem hiding this comment.
Looks like you accidentally pushed unrelated changes to this particular PR. Please can you clean these up so it's just the env var change?
PS you'll also need to update the PR description to use the standard structure and add a changelog.
github-project-automation
Bot
moved this to Reviewed PRs that need fixes
in Python PR digest
OTEL_SEMCONV_STABILITY_OPT_IN was not registered in environment_variables.py so the opentelemetry-instrument CLI did not expose a --semconv_stability_opt_in argument. Add the constant so the auto-instrumentation argument parser picks it up through the opentelemetry_environment_variables entry-point. Fixes open-telemetry#3965 Signed-off-by: alliasgher <alliasgher123@gmail.com>
alliasgher
force-pushed
the
fix-semconv-stability-cli-arg
branch
from
f761ca9 to
533693a
Compare
|
Cleaned up — the branch now contains only the |
Signed-off-by: Ali <alliasgher123@gmail.com>
MikeGoldsmith
left a comment
MikeGoldsmith
left a comment
There was a problem hiding this comment.
Looks good - thanks @alliasgher 👍🏻
github-project-automation
Bot
moved this from Reviewed PRs that need fixes
to Approved PRs
in Python PR digest
|
This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment. |
@MikeGoldsmith @tammy-baylis-swi approved but still marked stale |
tammy-baylis-swi
left a comment
tammy-baylis-swi
left a comment
There was a problem hiding this comment.
Re-approved and rm'd Stale label. Maintainers will also have to look at this.
3 participants
Description
Register in
opentelemetry-instrumentation/src/opentelemetry/instrumentation/environment_variables.pyso thatopentelemetry-instrumentautomatically exposes a--semconv_stability_opt_inCLI argument via its env-var-driven arg parser.Without this registration the flag simply did not exist at the CLI level, forcing users to set the env var directly rather than using the instrumentation command's argument.
Fixes #3965
Type of change
Checklist
Unreleased / Added