Skip to content

fix(pyramid): add missing http.response.status_code in duration metrics #4448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dominod-dev wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(pyramid): add missing http.response.status_code in duration metrics #4448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
405d586
fix(pyramid): add missing http.response.status_code in duration metrics
dominod-dev Apr 16, 2026
5f143e5
Merge branch 'main' into add_http_response_status_code_pyramid
herin049 Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...ntelemetry-instrumentation-pyramid/src/opentelemetry/instrumentation/pyramid/callbacks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
ERROR_TYPE,
)
from opentelemetry.semconv._incubating.attributes.http_attributes import (
HTTP_RESPONSE_STATUS_CODE,
HTTP_STATUS_CODE,
)
from opentelemetry.semconv.attributes.http_attributes import HTTP_ROUTE
Expand Down Expand Up @@ -265,9 +266,8 @@ def trace_tween(request):
status = getattr(response, "status", status)
status_code = otel_wsgi._parse_status_code(status)
if status_code is not None:
duration_attrs[HTTP_STATUS_CODE] = (
otel_wsgi._parse_status_code(status)
)
duration_attrs[HTTP_STATUS_CODE] = status_code
duration_attrs[HTTP_RESPONSE_STATUS_CODE] = status_code

# Record metrics for old semconv (milliseconds)
if duration_histogram_old:
Expand Down
1 change: 1 addition & 0 deletions instrumentation/opentelemetry-instrumentation-pyramid/tests/test_automatic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,7 @@ def _verify_metric_names(

def _verify_duration_point(self, point):
self.assertIn(HTTP_REQUEST_METHOD, point.attributes)
self.assertIn(HTTP_RESPONSE_STATUS_CODE, point.attributes)
self.assertIn(URL_SCHEME, point.attributes)
self.assertNotIn(HTTP_METHOD, point.attributes)
self.assertNotIn(HTTP_SCHEME, point.attributes)
Expand Down