feat: Adding pydantic validation for strong typing in anthropic.#4475
Closed
eternalcuriouslearner wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
Contributor
|
Based on discussion from the SIG, it would be preferable to limit the dependence on |
Contributor
Author
|
Based on our discussion during SIG meeting and @herin049's suggestion I am closing this pr as current codebase uses pydantic models for server side responses and handles the request attributes as TypedDicts. |
eternalcuriouslearner
deleted the
pr/suryateja/add-pydantic-validation-around-anthropic-types
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add pydantic validation around Anthropic sdk's types.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ran the test suite to check if the current change is breaking the instrumentation or not.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.