Add reasoning tokens attribute to span / log when new sem conv is set#4493
Merged
lzchen merged 4 commits intoopen-telemetry:mainfrom Apr 30, 2026
Merged
Conversation
8 tasks
eternalcuriouslearner
approved these changes
Apr 29, 2026
lzchen
approved these changes
Apr 30, 2026
Contributor
lzchen
left a comment
lzchen
left a comment
There was a problem hiding this comment.
LGTM. Are there plans on moving this instrumentation to use TelemetryHandler in genai utils? We could probably add reason_tokens to InferenceInvocation too (separate pr).
Contributor
Author
|
Yeah I can take a stab at moving it over sometime in the next week |
Contributor
|
Oh looks like you did identify this as a duplicate of #4206, @DylanRussell please let us know what you decide to do here :) |
Contributor
Author
|
Yeah I think lets just merge this one and close the other ones.. it doesn't really matter tho, they are identical |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the reasoning token attribute defined in https://github.com/open-telemetry/semantic-conventions/pull/3383/changes to spans / logs when the new semconv flag is set.
Also adds reasoning tokens to output tokens as per the sem conv..
Fixes #3890
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit tests
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.