Skip to content

fix(celery): type getter and harden utility helpers#4505

Merged
aabmass merged 5 commits into
open-telemetry:mainfrom
diogosilva30:chore/celery-housekeeping
May 14, 2026
Merged

fix(celery): type getter and harden utility helpers#4505
aabmass merged 5 commits into
open-telemetry:mainfrom
diogosilva30:chore/celery-housekeeping

Conversation

@diogosilva30
Copy link
Copy Markdown
Contributor

@diogosilva30 diogosilva30 commented Apr 29, 2026

Description

Split out of #4439.

This PR keeps only the Celery housekeeping changes:

  • type CeleryGetter and normalize its returned values
  • add null guards and helper typing in utils.py
  • refine utility helper protocols and context aliases to match actual call sites
  • update getter tests to match the typed behavior
  • add a Sphinx nitpick exception for celery.worker.request.Request used in the documented getter type annotation

Testing

  • uv run tox -e py311-test-instrumentation-celery -- -q
  • uv run tox -e docs -- -W

@diogosilva30 diogosilva30 marked this pull request as draft April 29, 2026 16:36
@diogosilva30 diogosilva30 marked this pull request as ready for review May 5, 2026 14:45
@diogosilva30 diogosilva30 requested a review from a team as a code owner May 5, 2026 14:59
@MikeGoldsmith MikeGoldsmith changed the title chore(celery): type getter and harden utility helpers fix(celery): type getter and harden utility helpers May 11, 2026
Copy link
Copy Markdown
Member

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @diogosilva30 🚀

@github-project-automation github-project-automation Bot moved this to Approved PRs in Python PR digest May 11, 2026
@diogosilva30 diogosilva30 force-pushed the chore/celery-housekeeping branch from 1f3d41e to 0e7ec3a Compare May 12, 2026 21:23
@diogosilva30
Copy link
Copy Markdown
Contributor Author

diogosilva30 commented May 12, 2026

@MikeGoldsmith rebased from main, and added towncrier fragment instead of changelog edit

@emdneto
Copy link
Copy Markdown
Member

emdneto commented May 12, 2026

Thanks for the PR!

Just a heads-up: we no longer update CHANGELOG.md directly. The changelog is now generated from changelog fragments using Towncrier.

Please add the appropriate changelog fragment for this change instead of editing CHANGELOG.md manually. You can find the instructions and expected format in CONTRIBUTING.md.

@aabmass aabmass moved this from Approved PRs to Ready for merge in Python PR digest May 13, 2026
@aabmass aabmass added this pull request to the merge queue May 13, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks May 14, 2026
@aabmass aabmass added this pull request to the merge queue May 14, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks May 14, 2026
@aabmass aabmass enabled auto-merge (squash) May 14, 2026 14:58
@aabmass aabmass merged commit a80c7da into open-telemetry:main May 14, 2026
751 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for merge to Done in Python PR digest May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants