Fix flaky tornado test by increasing delta tolerance to 0.02#4550
Merged
Conversation
The test_metrics_concurrent_requests test was flaky on pypy/ubuntu because the delta between server and client duration for fast async requests can exceed 0.01 seconds due to scheduling jitter. Assisted-by: Claude Sonnet 4 Agent-Logs-Url: https://github.com/open-telemetry/opentelemetry-python-contrib/sessions/a65606a0-612d-49b2-bcda-8b3942ee3e63 Co-authored-by: xrmx <12932+xrmx@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix flaky tornado test on PyPy and Ubuntu
Fix flaky tornado test by increasing delta tolerance to 0.02
May 7, 2026
xrmx
approved these changes
May 7, 2026
MikeGoldsmith
approved these changes
May 7, 2026
github-project-automation
Bot
moved this from Easy to review / merge / close
to Approved PRs
in Python PR digest
github-project-automation
Bot
moved this from Ready for merge
to Done
in Python PR digest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test_metrics_concurrent_requestsis flaky on pypy/ubuntu — the server-vs-client duration delta for the fast/asyncrequest exceeds the 0.01s tolerance due to scheduling jitter. Bumps to 0.02s.Fixes #4070
Type of change
How Has This Been Tested?
test_metrics_concurrent_requestswith relaxed deltaDoes This PR Require a Core Repo Change?
Checklist: