Skip to content

fix(pika): pass destination instead of task_name to _enrich_span #4563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GitanshKapoor wants to merge 9 commits into
base: main
Choose a base branch
from
+9 −2
Open

fix(pika): pass destination instead of task_name to _enrich_span #4563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
42f8763
Update span enrichment to use destination instead of task_name
GitanshKapoor May 10, 2026
7f626ec
Refactor enrich_span assertion in test_utils.py
GitanshKapoor May 10, 2026
52f8a6d
Update CHANGELOG.md
GitanshKapoor May 10, 2026
b074be1
Update CHANGELOG with recent fixes and improvements
GitanshKapoor May 11, 2026
00d8b11
Merge branch 'main' into fix/pika-update-destination-property
GitanshKapoor May 11, 2026
410a9b7
Update CHANGELOG.md
GitanshKapoor May 13, 2026
c18860b
Add changelog fragment for pika destination fix
GitanshKapoor May 13, 2026
d96afc3
Merge branch 'open-telemetry:main' into fix/pika-update-destination-p…
GitanshKapoor May 13, 2026
38a0b59
Merge branch 'main' into fix/pika-update-destination-property
GitanshKapoor May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/4563.fixed
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
'opentelemetry-instrumentation-pika': pass destination to _enrich_span instead of task_name
Copy link
Copy Markdown
Contributor

@tammy-baylis-swi tammy-baylis-swi May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

Suggested change
'opentelemetry-instrumentation-pika': pass destination to _enrich_span instead of task_name
`opentelemetry-instrumentation-pika`: pass destination to _enrich_span instead of task_name

2 changes: 1 addition & 1 deletion ...tation/opentelemetry-instrumentation-pika/src/opentelemetry/instrumentation/pika/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ def _get_span(
kind=span_kind,
)
if span.is_recording():
_enrich_span(span, channel, properties, task_name, operation)
_enrich_span(span, channel, properties, destination, operation)
return span


Expand Down
8 changes: 7 additions & 1 deletion instrumentation/opentelemetry-instrumentation-pika/tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,13 @@ def test_get_span(
tracer.start_span.assert_called_once_with(
name=generate_span_name.return_value, kind=span_kind
)
enrich_span.assert_called_once()
enrich_span.assert_called_once_with(
tracer.start_span.return_value,
channel,
properties,
destination,
None,
)

@mock.patch("opentelemetry.context.get_value")
@mock.patch("opentelemetry.instrumentation.pika.utils._generate_span_name")
Expand Down