Migrate Google's GenAi Instrumentation Library to use the GenAi utils package#4571
Closed
DylanRussell wants to merge 15 commits into
Closed
Migrate Google's GenAi Instrumentation Library to use the GenAi utils package#4571DylanRussell wants to merge 15 commits into
DylanRussell wants to merge 15 commits into
Conversation
…entelemetry-python-contrib into stash_gencontent_changes
lmolkova
reviewed
May 12, 2026
lmolkova
approved these changes
May 12, 2026
lmolkova
requested changes
May 13, 2026
lmolkova
left a comment
lmolkova
left a comment
Member
There was a problem hiding this comment.
sorry @DylanRussell could you please reopen it against https://github.com/open-telemetry/opentelemetry-python-genai ?
github-project-automation
Bot
moved this from Approved PRs
to Reviewed PRs that need fixes
in Python PR digest
Contributor
Author
|
OK closing this. Opened open-telemetry/opentelemetry-python-genai#10 |
github-project-automation
Bot
moved this from Reviewed PRs that need fixes
to Done
in Python PR digest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This requires #4570 to get merged and then a release of the GenAi utils package, but I want to get input on this and make sure no additional changes would be needed to the GenAi utils package.. Some tests will fail until we get that merged and release completed..
This does ultimately make some breaking changes to the execute tool span attributes, removing some superfluous / unnecessary span attributes, and adding other sem conv compliant attributes.. It's possible to preserve the existing ones, but I don't see any value in keeping them, they would be redundant with the new compliant sem conv attributes..
Outside of that, switching over doesn't change / break anything AFAICT...
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit tests
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.