Skip to content

Commit 242dc03

Browse files
fix: address Copilot review comments
1 parent 01ee371 commit 242dc03

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

instrumentation/opentelemetry-instrumentation-genai-langchain/src/opentelemetry/instrumentation/genai/langchain/callback_handler.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -233,10 +233,10 @@ def on_chat_model_start(
233233
top_p = params.get("top_p")
234234
frequency_penalty = params.get("frequency_penalty")
235235
presence_penalty = params.get("presence_penalty")
236-
stop_sequences = params.get("stop") or params.get("stop_sequences")
236+
stop_sequences = params.get("stop") if params.get("stop") is not None else params.get("stop_sequences")
237237
seed = params.get("seed")
238238
temperature = params.get("temperature")
239-
max_tokens = params.get("max_completion_tokens") or params.get("max_tokens")
239+
max_tokens = params.get("max_completion_tokens") if params.get("max_completion_tokens") is not None else params.get("max_tokens")
240240

241241
provider = "unknown"
242242
if metadata is not None:

instrumentation/opentelemetry-instrumentation-genai-langchain/tests/test_llm_call.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ def test_chat_anthropic_claude_sonnet_llm_call(
198198
spans = span_exporter.get_finished_spans()
199199
assert len(spans) == 1
200200
span = spans[0]
201-
assert span.attributes.get("gen_ai.request.model") == "claude-sonnet-4-5"
201+
assert span.attributes.get(gen_ai_attributes.GEN_AI_REQUEST_MODEL) == "claude-sonnet-4-5"
202202

203203

204204
# span_exporter, start_instrumentation, gemini are coming from fixtures defined in conftest.py

0 commit comments

Comments
 (0)