lint

Author: lmolkova

instrumentation/opentelemetry-instrumentation-genai-openai-agents/.changelog/86.changed

@@ -1 +1,14 @@
-Rewrite on top of `opentelemetry-util-genai`. The instrumentor now registers a single `TracingProcessor` with the agents library (`agents.tracing.add_trace_processor`) and turns its `Trace` / `AgentSpan` / `FunctionSpan` callbacks into `invoke_workflow` / `invoke_agent` / `execute_tool` spans. The workflow span carries a `gen_ai.workflow.name` attribute sourced from the agents library's `RunConfig.workflow_name`. LLM-level spans are not emitted by this package — install `opentelemetry-instrumentation-genai-openai` alongside to capture them. Removes the `OTEL_INSTRUMENTATION_OPENAI_AGENTS_*` environment variables and the matching instrumentor kwargs. New `disable_openai_trace_export=True` instrumentor kwarg replaces the default OpenAI-hosted trace exporter so traces flow only via OTel. Handoff / guardrail / speech / transcription spans are no longer emitted pending semconv. `execute_tool` spans are missing `gen_ai.tool.call.id` because the agents library's `FunctionSpanData` does not expose it — tracked in [#86](https://github.com/open-telemetry/opentelemetry-python-genai/issues/86).
+Rewrite on top of `opentelemetry-util-genai`:
+
+- Emits `invoke_workflow`, `invoke_agent`, `execute_tool` spans via a `TracingProcessor` 
+  registered with `agents.tracing.add_trace_processor`.
+- Workflow span carries `gen_ai.workflow.name` from `RunConfig.workflow_name`.
+- LLM spans (`chat` / `responses` / `embeddings`) now come from 
+  `opentelemetry-instrumentation-genai-openai` when installed; this package no longer 
+  emits them.
+- Handoff / guardrail / speech / transcription spans are no longer emitted, pending semconv.
+- New `disable_openai_trace_export=True` instrumentor kwarg removes the default 
+  OpenAI-hosted trace exporter.
+- Removes the `OTEL_INSTRUMENTATION_OPENAI_AGENTS_*` env vars and matching instrumentor kwargs.
+
+Known gap: `execute_tool` spans are missing `gen_ai.tool.call.id` because the agents library's `FunctionSpanData` does not expose it ([#86](https://github.com/open-telemetry/opentelemetry-python-genai/issues/86)).

instrumentation/opentelemetry-instrumentation-genai-openai-agents/examples/manual/main.py

@@ -32,15 +32,11 @@
 from opentelemetry.sdk.trace.export import BatchSpanProcessor
 
 
-def configure_otel() -> (
-    tuple[TracerProvider, MeterProvider, LoggerProvider]
-):
+def configure_otel() -> tuple[TracerProvider, MeterProvider, LoggerProvider]:
     """Configure OpenTelemetry providers and install the instrumentor."""
 
     tracer_provider = TracerProvider()
-    tracer_provider.add_span_processor(
-        BatchSpanProcessor(OTLPSpanExporter())
-    )
+    tracer_provider.add_span_processor(BatchSpanProcessor(OTLPSpanExporter()))
     trace.set_tracer_provider(tracer_provider)
 
     meter_provider = MeterProvider(

instrumentation/opentelemetry-instrumentation-genai-openai-agents/src/opentelemetry/instrumentation/genai/openai_agents/processor.py

@@ -70,9 +70,9 @@ class GenAITracingProcessor(TracingProcessor):
     def __init__(self, handler: TelemetryHandler, provider: str) -> None:
         self._handler = handler
         self._provider = provider
-        self._invocations: weakref.WeakKeyDictionary[
-            Any, GenAIInvocation
-        ] = weakref.WeakKeyDictionary()
+        self._invocations: weakref.WeakKeyDictionary[Any, GenAIInvocation] = (
+            weakref.WeakKeyDictionary()
+        )
 
     def on_trace_start(self, trace: Trace) -> None:
         # ``trace.name`` comes from ``RunConfig.workflow_name`` (default

instrumentation/opentelemetry-instrumentation-genai-openai-agents/tests/conformance/orchestration.py

@@ -74,9 +74,7 @@ class OrchestrationScenario(Scenario):
         "invoke_agent",
         "execute_tool",
     )
-    expected_metrics = (
-        "gen_ai.client.operation.duration",
-    )
+    expected_metrics = ("gen_ai.client.operation.duration",)
     expected_violations = (
         # `FunctionSpanData` in the openai-agents library doesn't expose
         # `tool_call_id`, so our `execute_tool` spans can't set

instrumentation/opentelemetry-instrumentation-genai-openai-agents/tests/test_instrumentor.py

@@ -49,7 +49,9 @@ def test_instrument_adds_processor_alongside_default() -> None:
     assert len(_our_processors()) == 0
 
 
-def test_instrument_with_disable_openai_trace_export_replaces_processors() -> None:
+def test_instrument_with_disable_openai_trace_export_replaces_processors() -> (
+    None
+):
     # Make sure the default processor is registered before we start,
     # so the "replace" behavior is observable.
     agents.tracing.set_trace_processors(

instrumentation/opentelemetry-instrumentation-genai-openai-agents/tests/test_processor.py

@@ -3,7 +3,7 @@
 
 from __future__ import annotations
 
-from types import SimpleNamespace
+import gc
 from typing import Any
 from unittest.mock import MagicMock
 
@@ -76,7 +76,9 @@ def test_agent_span_creates_invoke_local_agent() -> None:
     handler.invoke_local_agent.return_value.stop.assert_called_once_with()
 
 
-def test_function_span_creates_tool_invocation_and_sets_provider_metric() -> None:
+def test_function_span_creates_tool_invocation_and_sets_provider_metric() -> (
+    None
+):
     handler = _build_handler()
     handler.tool.return_value = MagicMock(
         spec=ToolInvocation, metric_attributes={}
@@ -98,8 +100,7 @@ def test_function_span_creates_tool_invocation_and_sets_provider_metric() -> Non
     )
     tool_invocation = handler.tool.return_value
     assert (
-        tool_invocation.metric_attributes["gen_ai.provider.name"]
-        == "openai"
+        tool_invocation.metric_attributes["gen_ai.provider.name"] == "openai"
     )
 
     # Output gets populated on the agents library span_data after the
@@ -182,8 +183,6 @@ def test_shutdown_stops_open_invocations() -> None:
 
 
 def test_state_uses_weakref_so_dropped_spans_are_collected() -> None:
-    import gc
-
     handler = _build_handler()
     processor = GenAITracingProcessor(handler, provider="openai")
     span: _Span | None = _Span(AgentSpanData(name="triage"))

util/opentelemetry-test-util-genai/src/opentelemetry/test_util_genai/conformance.py

@@ -84,10 +84,10 @@ class ExpectedViolation:
     message_substring: str
 
     def matches(self, violation: dict[str, Any]) -> bool:
-        return (
-            violation.get("id") == self.advice_id
-            and self.message_substring
-            in str(violation.get("message", ""))
+        return violation.get(
+            "id"
+        ) == self.advice_id and self.message_substring in str(
+            violation.get("message", "")
         )
 
 
@@ -236,17 +236,13 @@ def run_conformance(
         logger_provider.shutdown()
 
 
-def _check_violations(
-    scenario: Scenario, report: LiveCheckReport
-) -> None:
+def _check_violations(scenario: Scenario, report: LiveCheckReport) -> None:
     """Reconcile weaver violations against ``scenario.expected_violations``."""
     violations = report.violations
     expected = scenario.expected_violations
 
     unexpected = [
-        v
-        for v in violations
-        if not any(ev.matches(v) for ev in expected)
+        v for v in violations if not any(ev.matches(v) for ev in expected)
     ]
     if unexpected:
         raise LiveCheckError(