Skip to content

Commit c92aad9

Browse files
lmolkovaCopilottrask
authored
Apply suggestions from code review
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
1 parent 26d0894 commit c92aad9

3 files changed

Lines changed: 6 additions & 4 deletions

File tree

.github/skills/migrate-from-openinference/SKILL.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ User specifies the source, e.g. `openinference-instrumentation-crewai`.
3737
and use `/tmp/openinference/python/instrumentation/<source>/` as the
3838
source path in step 1.
3939

40-
User may also provide ***target package name**. If not provided: derive it from the source name:
40+
User may also provide the **target package name**. If not provided: derive it from the source name:
4141
- drop the leading `openinference-instrumentation-`. Remaining part should match the instrumented library name as it appears on PyPI. If it's not the case, flag it.
4242
- The target package name should be `opentelemetry-instrumentation-genai-<lib>` where `<lib>` is the instrumented library name (e.g. `openai`, `anthropic`, `bedrock`). For example:
4343
- `openinference-instrumentation-openai``opentelemetry-instrumentation-genai-openai`
@@ -286,12 +286,12 @@ Update every import. Verify zero `openinference` references remain in
286286
`BaseInstrumentor`) and the underlying SDK (`openai`, `anthropic`, …) at
287287
the same range OpenInference was using.
288288
- `__version__` in `version.py` should equal the value in
289-
`opentelemetry-util-genai/src/opentelemetry/util/genai/version.py` — all
289+
`util/opentelemetry-util-genai/src/opentelemetry/util/genai/version.py` — all
290290
workspace packages share one version. Verify:
291291

292292
```sh
293293
diff <(grep ^__version__ instrumentation/<target>/src/opentelemetry/instrumentation/genai/<lib>/version.py) \
294-
<(grep ^__version__ opentelemetry-util-genai/src/opentelemetry/util/genai/version.py)
294+
<(grep ^__version__ util/opentelemetry-util-genai/src/opentelemetry/util/genai/version.py)
295295
```
296296

297297
- Hatchling builds **require a `README.md` or `README.rst`**. Rewrite it to

.github/skills/review-migration/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ scenarios per operation are fine but never required.
265265
| Operation | Scenario file | Status |
266266
|---|---|---|
267267

268-
Mention if conformance scenatio is skipped, there are expected_violations,
268+
Mention if conformance scenario is skipped, there are expected_violations,
269269
or `uv run tox -e py312-test-instrumentation-genai-<lib>` fails.
270270

271271
#### 4c. Docstring / README coverage

CONTRIBUTING.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,8 @@ you start one of these tasks:
141141
- **`write-conformance-tests`** — author conformance scenarios and the
142142
`test_conformance.py` runner for an instrumentation package.
143143

144+
Please contribute back anything you learn while using the skills that could help improve them!
145+
144146
## Keep PRs small
145147

146148
One logical change per PR. Don't bundle unrelated fixes, refactors, or

0 commit comments

Comments
 (0)