Add LangChain invoke workflow and invoke agent span support#25
Merged
Conversation
…hon-genai into chains-langchain
Member
|
FYI if your PR needs a changelog entry, please update it to use towncrier #16 |
lzchen
reviewed
May 18, 2026
lzchen
reviewed
May 18, 2026
lmolkova
reviewed
May 19, 2026
lmolkova
left a comment
lmolkova
left a comment
Member
There was a problem hiding this comment.
Thanks, it looks good! I've read #28 and agree with this modeling. Just a few minor concerns.
lmolkova
approved these changes
May 20, 2026
| # Most instrumentations should have agent.id; flag it as always-emit. | ||
| _invoke_agent_expected := { | ||
| "gen_ai.operation.name", | ||
| "gen_ai.provider.name", |
Member
There was a problem hiding this comment.
should we have gen_ai.t.name here instead?
Contributor
Author
lzchen
approved these changes
May 20, 2026
Add missing py312/py313 test jobs for instrumentation-langchain. Assisted-by: Claude Opus 4.6
…hon-genai into chains-langchain
DylanRussell
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brought from old repo: open-telemetry/opentelemetry-python-contrib#4449
Note: Current PR generates
invoke_agentspans when genuine react agent eg: create_react_agent. Opened issue to discuss which span we want when there are plain langgraph nodes(without any actual agent)