fix some versions not being bumped before release and issue behind it#250
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a release workflow race where the bump-main job could run before the finalize matrix finished creating GitHub release tags, causing some packages to miss their post-release .dev version bump. It also manually corrects the affected package versions so they’re back in sync with the rest of the workspace.
Changes:
- Fix release workflow ordering by making
bump-maindepend onfinalize, preventing tag-visibility races. - Bump
opentelemetry-util-genaiversion to1.1b0.dev. - Bump
opentelemetry-instrumentation-google-genaiversion to1.1b0.dev.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
util/opentelemetry-util-genai/src/opentelemetry/util/genai/version.py |
Updates util package to the next .dev version after release. |
instrumentation/opentelemetry-instrumentation-google-genai/src/opentelemetry/instrumentation/google_genai/version.py |
Updates google-genai instrumentation package to the next .dev version after release. |
.github/workflows/release-all.yml |
Prevents bump-main from running before finalize completes, avoiding missed bumps. |
|
This PR has review comments. Review suggestions, whether from maintainers or automated reviewers, aren't always correct or required. Please evaluate each comment on its merits, then make sure each thread has a clear outcome. For example, link to the commit if you applied a suggestion, explain why it wasn't applied, or ask a follow-up question. Automation flags a PR for human review once every review thread has a reply or is marked as resolved. Status across open PRs is visible on the pull request dashboard. |
8bbcd98
Smart AI figured it out.
bump-main job (which bumps versions to the next .dev version) ran in parallel with the finalize matrix jobs (which create the GitHub release tags).
Because bump-main only depended on [enumerate, publish], it checked for release tags via gh release view while the finalize jobs were still running. This race condition caused some package tags to not be found at the check time, skipping their version bump. Specifically, opentelemetry-instrumentation-google-genai and opentelemetry-util-genai were skipped, leaving them stuck at 1.0b0 instead of 1.1b0.dev.
Bump PR: #240