Fix prepare release and remove patch-from-main scenario #264
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the prepare-release workflow failure caused by unsupported gh pr create --json/--jq flags, and updates the release process to always bump main to the next minor .dev line after a release (removing the “patch-from-main” path). It also updates release documentation and scripts to reflect the new model.
Changes:
- Fix
prepare-release.ymlPR URL handling by removing unsupportedgh pr create --json/--jqflags. - Remove
bump_package_dev_version.shand switch post-release bumping tobump_package_minor_version.shin release workflows. - Update
RELEASING.mdand script comments to document that patches are cut frompackage-release/<pkg>/v*branches.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
scripts/bump_package_minor_version.sh |
Clarifies intended usage: post-release bump to next unreleased minor; patches are not done on main. |
scripts/bump_package_dev_version.sh |
Removes the patch-increment dev bump script in favor of always bumping to next minor on main. |
RELEASING.md |
Updates the documented version/release model to match “main always on next minor” and patch-from-branch. |
.github/workflows/release-all.yml |
Switches post-release bumping from patch-dev to next minor .dev. |
.github/workflows/prepare-release.yml |
Removes unsupported gh pr create --json/--jq usage that caused the workflow failure. |
.github/workflows/_release-finalize.yml |
Switches post-release bumping on main to the next minor .dev. |
|
This PR has review comments. Review suggestions, whether from maintainers or automated reviewers, aren't always correct or required. Please evaluate each comment on its merits, then make sure each thread has a clear outcome. For example, link to the commit if you applied a suggestion, explain why it wasn't applied, or ask a follow-up question. Automation flags a PR for human review once every review thread has a reply or is marked as resolved. Status across open PRs is visible on the pull request dashboard. |
d83930e
Prepare release fails https://github.com/open-telemetry/opentelemetry-python-genai/actions/runs/29276045727
Fixing it, but also removing patch-from-main release - main is bumped right after the release and patching it means downgrading version to prev one. Let's just have one way to patch regardless of current/ old version