Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

google-genai ~= 1.0.0
google-genai ~=1.75.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any concern with it?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looked intentional to test against 1.0, as in saying that the instrumentation is compatible with 1.0

e.g. in Java instrumentation we test against an earliest library baseline as well as the latest library release

I wasn't sure what existing policy here is, though given the fast pace of GenAI, I would support only testing against latest

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not even tests, just examples. We should run them against latest (which is at 2.4, renovate didn't want to update major version? 🤔)

I'm thinking we should either replace these with conformance tests or make them testable.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renovate didn't want to update major version?

it likes to separate minor updates from major updates, it's got a lot of updates queued for this repo: #1

I didn't want to mass request them myself until I had a better understanding of this repo's dependencies, no need for me to be a blocker here, though I do plan to spend some time this week to better understand the dependency story

opentelemetry-api ~=1.41.1
opentelemetry-sdk ~=1.41.1
opentelemetry-exporter-otlp-proto-grpc ~=1.41.1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

google-genai ~= 1.0.0
google-genai ~=1.75.0
opentelemetry-api ~=1.41.1
opentelemetry-sdk ~=1.41.1
opentelemetry-exporter-otlp-proto-grpc ~=1.41.1
Expand Down
Loading