opentelemetry-exporter-otlp-proto-http: enable typechecking (#5028)

Co-authored-by: Leighton Chen <lechen@microsoft.com>

Author: xrmx

exporter/opentelemetry-exporter-otlp-proto-http/src/opentelemetry/exporter/otlp/proto/http/_common/__init__.py

@@ -19,9 +19,6 @@
 
 from opentelemetry.sdk.environment_variables import (
     _OTEL_PYTHON_EXPORTER_OTLP_HTTP_CREDENTIAL_PROVIDER,
-    _OTEL_PYTHON_EXPORTER_OTLP_HTTP_LOGS_CREDENTIAL_PROVIDER,
-    _OTEL_PYTHON_EXPORTER_OTLP_HTTP_METRICS_CREDENTIAL_PROVIDER,
-    _OTEL_PYTHON_EXPORTER_OTLP_HTTP_TRACES_CREDENTIAL_PROVIDER,
 )
 from opentelemetry.util._importlib_metadata import entry_points
 
@@ -36,9 +33,9 @@ def _is_retryable(resp: requests.Response) -> bool:
 
 def _load_session_from_envvar(
     cred_envvar: Literal[
-        _OTEL_PYTHON_EXPORTER_OTLP_HTTP_LOGS_CREDENTIAL_PROVIDER,
-        _OTEL_PYTHON_EXPORTER_OTLP_HTTP_TRACES_CREDENTIAL_PROVIDER,
-        _OTEL_PYTHON_EXPORTER_OTLP_HTTP_METRICS_CREDENTIAL_PROVIDER,
+        "OTEL_PYTHON_EXPORTER_OTLP_HTTP_LOGS_CREDENTIAL_PROVIDER",
+        "OTEL_PYTHON_EXPORTER_OTLP_HTTP_TRACES_CREDENTIAL_PROVIDER",
+        "OTEL_PYTHON_EXPORTER_OTLP_HTTP_METRICS_CREDENTIAL_PROVIDER",
     ],
 ) -> Optional[requests.Session]:
     _credential_env = environ.get(

exporter/opentelemetry-exporter-otlp-proto-http/src/opentelemetry/exporter/otlp/proto/http/metric_exporter/__init__.py

@@ -443,6 +443,11 @@ def _split_metrics_data(
 
                         # Rebuild metric dict generically using same approach as initial creation
                         field_name = metric.WhichOneof("data")
+                        if field_name is None:
+                            _logger.warning(
+                                "Tried to split and export an unsupported metric type. Skipping."
+                            )
+                            continue
                         data_container = getattr(metric, field_name)
                         metric_dict = {
                             "name": metric.name,
@@ -552,13 +557,13 @@ def _get_split_resource_metrics_pb2(
         new_resource_metrics = pb2.ResourceMetrics(
             resource=resource_metrics.get("resource"),
             scope_metrics=[],
-            schema_url=resource_metrics.get("schema_url"),
+            schema_url=resource_metrics.get("schema_url") or "",
         )
         for scope_metrics in resource_metrics.get("scope_metrics", []):
             new_scope_metrics = pb2.ScopeMetrics(
                 scope=scope_metrics.get("scope"),
                 metrics=[],
-                schema_url=scope_metrics.get("schema_url"),
+                schema_url=scope_metrics.get("schema_url") or "",
             )
 
             for metric in scope_metrics.get("metrics", []):

pyproject.toml

@@ -120,6 +120,7 @@ include = [
   "opentelemetry-sdk",
   "opentelemetry-proto-json",
   "exporter/opentelemetry-exporter-otlp-proto-grpc",
+  "exporter/opentelemetry-exporter-otlp-proto-http",
   "codegen/opentelemetry-codegen-json"
 ]
 
@@ -129,6 +130,7 @@ exclude = [
   "opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/",
   "opentelemetry-sdk/benchmarks",
   "exporter/opentelemetry-exporter-otlp-proto-grpc/tests",
+  "exporter/opentelemetry-exporter-otlp-proto-http/tests",
 ]
 
 # When packages are correct typed add them to the strict list