Skip to content

Commit 04f179c

Browse files
JayeshHireJayeshHire
committed
resolved TCH-rule errors
1 parent f77df20 commit 04f179c

5 files changed

Lines changed: 62 additions & 53 deletions

File tree

‎opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@
5151
LoggingHandler,
5252
LogRecordProcessor,
5353
)
54-
from opentelemetry.sdk._logs._internal import _LoggerConfiguratorT
5554
from opentelemetry.sdk._logs.export import (
5655
BatchLogRecordProcessor,
5756
LogRecordExporter,
@@ -88,6 +87,7 @@
8887
from opentelemetry.util._importlib_metadata import entry_points
8988

9089
if TYPE_CHECKING:
90+
from opentelemetry.sdk._logs._internal import _LoggerConfiguratorT
9191
from opentelemetry.sdk.metrics._internal import _MeterConfiguratorT
9292

9393

‎opentelemetry-sdk/src/opentelemetry/sdk/_configuration/_logger_provider.py‎

Lines changed: 25 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -15,40 +15,42 @@
1515
from __future__ import annotations
1616

1717
import logging
18-
from typing import Optional
18+
from typing import TYPE_CHECKING, Optional
1919

2020
from opentelemetry._logs import set_logger_provider
2121
from opentelemetry.sdk._configuration._common import _parse_headers
2222
from opentelemetry.sdk._configuration._exceptions import ConfigurationError
23-
from opentelemetry.sdk._configuration.models import (
24-
BatchLogRecordProcessor as BatchLogRecordProcessorConfig,
25-
)
26-
from opentelemetry.sdk._configuration.models import (
27-
LoggerProvider as LoggerProviderConfig,
28-
)
29-
from opentelemetry.sdk._configuration.models import (
30-
LogRecordExporter as LogRecordExporterConfig,
31-
)
32-
from opentelemetry.sdk._configuration.models import (
33-
LogRecordProcessor as LogRecordProcessorConfig,
34-
)
35-
from opentelemetry.sdk._configuration.models import (
36-
OtlpGrpcExporter as OtlpGrpcExporterConfig,
37-
)
38-
from opentelemetry.sdk._configuration.models import (
39-
OtlpHttpExporter as OtlpHttpExporterConfig,
40-
)
41-
from opentelemetry.sdk._configuration.models import (
42-
SimpleLogRecordProcessor as SimpleLogRecordProcessorConfig,
43-
)
4423
from opentelemetry.sdk._logs import LoggerProvider
4524
from opentelemetry.sdk._logs._internal.export import (
4625
BatchLogRecordProcessor,
4726
ConsoleLogRecordExporter,
4827
LogRecordExporter,
4928
SimpleLogRecordProcessor,
5029
)
51-
from opentelemetry.sdk.resources import Resource
30+
31+
if TYPE_CHECKING:
32+
from opentelemetry.sdk._configuration.models import (
33+
BatchLogRecordProcessor as BatchLogRecordProcessorConfig,
34+
)
35+
from opentelemetry.sdk._configuration.models import (
36+
LoggerProvider as LoggerProviderConfig,
37+
)
38+
from opentelemetry.sdk._configuration.models import (
39+
LogRecordExporter as LogRecordExporterConfig,
40+
)
41+
from opentelemetry.sdk._configuration.models import (
42+
LogRecordProcessor as LogRecordProcessorConfig,
43+
)
44+
from opentelemetry.sdk._configuration.models import (
45+
OtlpGrpcExporter as OtlpGrpcExporterConfig,
46+
)
47+
from opentelemetry.sdk._configuration.models import (
48+
OtlpHttpExporter as OtlpHttpExporterConfig,
49+
)
50+
from opentelemetry.sdk._configuration.models import (
51+
SimpleLogRecordProcessor as SimpleLogRecordProcessorConfig,
52+
)
53+
from opentelemetry.sdk.resources import Resource
5254

5355
_logger = logging.getLogger(__name__)
5456

‎opentelemetry-sdk/src/opentelemetry/sdk/_configuration/_meter_provider.py‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
from __future__ import annotations
1616

1717
import logging
18-
from typing import Optional, Set, Type
18+
from typing import TYPE_CHECKING, Optional, Set, Type
1919

2020
from opentelemetry import metrics
2121
from opentelemetry.sdk._configuration._common import _parse_headers
@@ -85,7 +85,9 @@
8585
SumAggregation,
8686
View,
8787
)
88-
from opentelemetry.sdk.resources import Resource
88+
89+
if TYPE_CHECKING:
90+
from opentelemetry.sdk.resources import Resource
8991

9092
_logger = logging.getLogger(__name__)
9193

‎opentelemetry-sdk/src/opentelemetry/sdk/_configuration/_tracer_provider.py‎

Lines changed: 28 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -15,36 +15,11 @@
1515
from __future__ import annotations
1616

1717
import logging
18-
from typing import Optional
18+
from typing import TYPE_CHECKING, Optional
1919

2020
from opentelemetry import trace
2121
from opentelemetry.sdk._configuration._common import _parse_headers
2222
from opentelemetry.sdk._configuration._exceptions import ConfigurationError
23-
from opentelemetry.sdk._configuration.models import (
24-
OtlpGrpcExporter as OtlpGrpcExporterConfig,
25-
)
26-
from opentelemetry.sdk._configuration.models import (
27-
OtlpHttpExporter as OtlpHttpExporterConfig,
28-
)
29-
from opentelemetry.sdk._configuration.models import (
30-
ParentBasedSampler as ParentBasedSamplerConfig,
31-
)
32-
from opentelemetry.sdk._configuration.models import (
33-
Sampler as SamplerConfig,
34-
)
35-
from opentelemetry.sdk._configuration.models import (
36-
SpanExporter as SpanExporterConfig,
37-
)
38-
from opentelemetry.sdk._configuration.models import (
39-
SpanLimits as SpanLimitsConfig,
40-
)
41-
from opentelemetry.sdk._configuration.models import (
42-
SpanProcessor as SpanProcessorConfig,
43-
)
44-
from opentelemetry.sdk._configuration.models import (
45-
TracerProvider as TracerProviderConfig,
46-
)
47-
from opentelemetry.sdk.resources import Resource
4823
from opentelemetry.sdk.trace import (
4924
_DEFAULT_OTEL_EVENT_ATTRIBUTE_COUNT_LIMIT,
5025
_DEFAULT_OTEL_LINK_ATTRIBUTE_COUNT_LIMIT,
@@ -68,6 +43,33 @@
6843
TraceIdRatioBased,
6944
)
7045

46+
if TYPE_CHECKING:
47+
from opentelemetry.sdk._configuration.models import (
48+
OtlpGrpcExporter as OtlpGrpcExporterConfig,
49+
)
50+
from opentelemetry.sdk._configuration.models import (
51+
OtlpHttpExporter as OtlpHttpExporterConfig,
52+
)
53+
from opentelemetry.sdk._configuration.models import (
54+
ParentBasedSampler as ParentBasedSamplerConfig,
55+
)
56+
from opentelemetry.sdk._configuration.models import (
57+
Sampler as SamplerConfig,
58+
)
59+
from opentelemetry.sdk._configuration.models import (
60+
SpanExporter as SpanExporterConfig,
61+
)
62+
from opentelemetry.sdk._configuration.models import (
63+
SpanLimits as SpanLimitsConfig,
64+
)
65+
from opentelemetry.sdk._configuration.models import (
66+
SpanProcessor as SpanProcessorConfig,
67+
)
68+
from opentelemetry.sdk._configuration.models import (
69+
TracerProvider as TracerProviderConfig,
70+
)
71+
from opentelemetry.sdk.resources import Resource
72+
7173
_logger = logging.getLogger(__name__)
7274

7375
# Default sampler per the OTel spec: parent_based with always_on root.

‎opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/_exceptions.py‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,14 @@
1414
from __future__ import annotations
1515

1616
import traceback
17+
from typing import TYPE_CHECKING
1718

1819
from opentelemetry._logs import LogRecord
1920
from opentelemetry.attributes import BoundedAttributes
2021
from opentelemetry.semconv.attributes import exception_attributes
21-
from opentelemetry.util.types import AnyValue, _ExtendedAttributes
22+
23+
if TYPE_CHECKING:
24+
from opentelemetry.util.types import AnyValue, _ExtendedAttributes
2225

2326

2427
def _get_exception_attributes(

0 commit comments

Comments
 (0)