fix(config): scope deflate compression to OTLP HTTP

Author: officialasishkumar

opentelemetry-sdk/src/opentelemetry/sdk/_configuration/_common.py

@@ -52,18 +52,25 @@ def _parse_headers(
 
 
 def _map_compression(
-    value: Optional[str], compression_enum: type
+    value: Optional[str],
+    compression_enum: type,
+    *,
+    allow_deflate: bool = False,
 ) -> Optional[object]:
     """Map a compression string to the given Compression enum value."""
     if value is None or value.lower() == "none":
         return None
     if value.lower() == "gzip":
         return compression_enum.Gzip  # type: ignore[attr-defined]
-    if value.lower() == "deflate" and hasattr(compression_enum, "Deflate"):
+    if (
+        value.lower() == "deflate"
+        and allow_deflate
+        and hasattr(compression_enum, "Deflate")
+    ):
         return compression_enum.Deflate  # type: ignore[attr-defined]
 
     supported_values = ["'gzip'", "'none'"]
-    if hasattr(compression_enum, "Deflate"):
+    if allow_deflate and hasattr(compression_enum, "Deflate"):
         supported_values.insert(1, "'deflate'")
 
     raise ConfigurationError(

opentelemetry-sdk/src/opentelemetry/sdk/_configuration/_meter_provider.py

@@ -286,7 +286,9 @@ def _create_otlp_http_metric_exporter(
             "Install it with: pip install opentelemetry-exporter-otlp-proto-http"
         ) from exc
 
-    compression = _map_compression(config.compression, Compression)
+    compression = _map_compression(
+        config.compression, Compression, allow_deflate=True
+    )
     headers = _parse_headers(config.headers, config.headers_list)
     timeout = (config.timeout / 1000.0) if config.timeout is not None else None
     preferred_temporality = _map_temporality(config.temporality_preference)

opentelemetry-sdk/src/opentelemetry/sdk/_configuration/_tracer_provider.py

@@ -95,7 +95,9 @@ def _create_otlp_http_span_exporter(
             "Install it with: pip install opentelemetry-exporter-otlp-proto-http"
         ) from exc
 
-    compression = _map_compression(config.compression, Compression)
+    compression = _map_compression(
+        config.compression, Compression, allow_deflate=True
+    )
     headers = _parse_headers(config.headers, config.headers_list)
     timeout = (config.timeout / 1000.0) if config.timeout is not None else None
 

opentelemetry-sdk/tests/_configuration/test_common.py

@@ -108,15 +108,29 @@ def test_gzip_maps_to_gzip(self):
             _map_compression("gzip", _CompressionWithDeflate), "gzip"
         )
 
-    def test_deflate_maps_when_supported(self):
+    def test_deflate_maps_when_enabled(self):
         self.assertEqual(
-            _map_compression("deflate", _CompressionWithDeflate),
+            _map_compression(
+                "deflate", _CompressionWithDeflate, allow_deflate=True
+            ),
             "deflate",
         )
 
-    def test_deflate_raises_when_unsupported(self):
+    def test_deflate_raises_by_default(self):
         with self.assertRaises(ConfigurationError) as ctx:
-            _map_compression("deflate", _CompressionWithoutDeflate)
+            _map_compression("deflate", _CompressionWithDeflate)
+
+        self.assertEqual(
+            str(ctx.exception),
+            "Unsupported compression value 'deflate'. Supported values: "
+            "'gzip', 'none'.",
+        )
+
+    def test_deflate_raises_when_http_enum_lacks_support(self):
+        with self.assertRaises(ConfigurationError) as ctx:
+            _map_compression(
+                "deflate", _CompressionWithoutDeflate, allow_deflate=True
+            )
 
         self.assertEqual(
             str(ctx.exception),
@@ -126,7 +140,9 @@ def test_deflate_raises_when_unsupported(self):
 
     def test_http_error_message_includes_deflate(self):
         with self.assertRaises(ConfigurationError) as ctx:
-            _map_compression("brotli", _CompressionWithDeflate)
+            _map_compression(
+                "brotli", _CompressionWithDeflate, allow_deflate=True
+            )
 
         self.assertEqual(
             str(ctx.exception),