Commit 0fea141
committed
nit: drop sys.orig_argv fallback and use PR number in changelog
Two review nits from MikeGoldsmith:
- sys.orig_argv has been available since Python 3.10; the SDK now
requires 3.10+ so the getattr fallback is dead code. Use sys.orig_argv
directly and update the comment.
- CHANGELOG entries should reference the PR number, not the issue
number.
Signed-off-by: Ali <alliasgher123@gmail.com>1 parent a2914f3 commit 0fea141
File tree
3 files changed
+12
-12
lines changed- opentelemetry-sdk
- src/opentelemetry/sdk/resources
- tests/resources
3 files changed
+12
-12
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | | - | |
| 23 | + | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
Lines changed: 7 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
380 | 380 | | |
381 | 381 | | |
382 | 382 | | |
383 | | - | |
384 | | - | |
385 | | - | |
386 | | - | |
387 | | - | |
388 | | - | |
389 | | - | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
390 | 390 | | |
391 | 391 | | |
392 | 392 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
611 | 611 | | |
612 | 612 | | |
613 | 613 | | |
614 | | - | |
| 614 | + | |
615 | 615 | | |
616 | 616 | | |
617 | 617 | | |
618 | | - | |
| 618 | + | |
619 | 619 | | |
620 | 620 | | |
621 | 621 | | |
622 | | - | |
| 622 | + | |
623 | 623 | | |
624 | 624 | | |
625 | 625 | | |
| |||
0 commit comments