Skip to content

Commit 23c4e8e

Browse files
fix(sdk): move patch import to top level, fix trailing whitespace
1 parent cbcd0b5 commit 23c4e8e

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

opentelemetry-sdk/tests/metrics/test_periodic_exporting_metric_reader.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,7 @@ def test_metric_reader_metrics(self):
354354
assert isinstance(name, str)
355355
self.assertTrue(name.startswith("periodic_metric_reader/"))
356356

357-
mp.shutdown()
357+
mp.shutdown()
358358

359359
def test_force_flush_returns_true_on_success(self):
360360
exporter = FakeMetricsExporter()
@@ -393,15 +393,16 @@ def _collect_failure(reader, timeout_millis):
393393

394394
def test_detach_called_on_export_failure(self):
395395
"""detach(token) must run in finally even when export returns FAILURE."""
396-
from unittest.mock import patch
396+
import opentelemetry.sdk.metrics._internal.export as export_module
397397

398398
exporter = FakeMetricsExporter()
399399
exporter.export = Mock(return_value=MetricExportResult.FAILURE)
400400
pmr = self._create_periodic_reader(metrics, exporter)
401401

402402
with patch(
403-
"opentelemetry.sdk.metrics._internal.export.detach"
403+
"opentelemetry.sdk.metrics._internal.export.detach",
404+
wraps=export_module.detach,
404405
) as mock_detach:
405406
pmr.force_flush(timeout_millis=5_000)
407+
pmr.shutdown()
406408
self.assertTrue(mock_detach.called)
407-
pmr.shutdown()

0 commit comments

Comments
 (0)