Skip to content

Commit 2a8014e

Browse files
authored
opentelemetry-sdk: fix a bunch of trivial typing issues in metrics (#5033)
1 parent afcf8d7 commit 2a8014e

File tree

5 files changed

+20
-7
lines changed

5 files changed

+20
-7
lines changed

opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
# limitations under the License.
1414

1515

16+
from opentelemetry.sdk.metrics import export, view
1617
from opentelemetry.sdk.metrics._internal import Meter, MeterProvider
1718
from opentelemetry.sdk.metrics._internal.exceptions import MetricsTimeoutError
1819
from opentelemetry.sdk.metrics._internal.exemplar import (
@@ -54,4 +55,6 @@
5455
"SimpleFixedSizeExemplarReservoir",
5556
"UpDownCounter",
5657
"TraceBasedExemplarFilter",
58+
"export",
59+
"view",
5760
]

opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -680,7 +680,7 @@ def get_meter(
680680
version: Optional[str] = None,
681681
schema_url: Optional[str] = None,
682682
attributes: Optional[Attributes] = None,
683-
) -> Meter:
683+
) -> APIMeter:
684684
if self._disabled:
685685
return NoOpMeter(name, version=version, schema_url=schema_url)
686686

opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/measurement_consumer.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,15 +41,15 @@ def consume_measurement(self, measurement: Measurement) -> None:
4141
def register_asynchronous_instrument(
4242
self,
4343
instrument: (
44-
"opentelemetry.sdk.metrics._internal.instrument_Asynchronous"
44+
"opentelemetry.sdk.metrics._internal.instrument._Asynchronous"
4545
),
4646
):
4747
pass
4848

4949
@abstractmethod
5050
def collect(
5151
self,
52-
metric_reader: "opentelemetry.sdk.metrics.MetricReader",
52+
metric_reader: "opentelemetry.sdk.metrics.export.MetricReader",
5353
timeout_millis: float = 10_000,
5454
) -> Optional[MetricsData]:
5555
pass
@@ -102,7 +102,7 @@ def register_asynchronous_instrument(
102102

103103
def collect(
104104
self,
105-
metric_reader: "opentelemetry.sdk.metrics.MetricReader",
105+
metric_reader: "opentelemetry.sdk.metrics.export.MetricReader",
106106
timeout_millis: float = 10_000,
107107
) -> Optional[MetricsData]:
108108
with self._lock:

opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/sdk_configuration.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,5 @@
2626
class SdkConfiguration:
2727
exemplar_filter: "opentelemetry.sdk.metrics.ExemplarFilter"
2828
resource: "opentelemetry.sdk.resources.Resource"
29-
metric_readers: Sequence["opentelemetry.sdk.metrics.MetricReader"]
30-
views: Sequence["opentelemetry.sdk.metrics.View"]
29+
metric_readers: Sequence["opentelemetry.sdk.metrics.export.MetricReader"]
30+
views: Sequence["opentelemetry.sdk.metrics.view.View"]

pyproject.toml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,17 @@ include = [
127127
exclude = [
128128
"opentelemetry-sdk/tests",
129129
"opentelemetry-sdk/src/opentelemetry/sdk/_events",
130-
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/",
130+
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/__init__.py",
131+
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/_view_instrument_match.py",
132+
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/aggregation.py",
133+
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/exemplar/exemplar_reservoir.py",
134+
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/exponential_histogram/",
135+
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/export/",
136+
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/instrument.py",
137+
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/measurement_consumer.py",
138+
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/metric_reader_storage.py",
139+
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/point.py",
140+
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/view.py",
131141
"opentelemetry-sdk/benchmarks",
132142
"exporter/opentelemetry-exporter-otlp-proto-grpc/tests",
133143
"exporter/opentelemetry-exporter-otlp-proto-http/tests",

0 commit comments

Comments
 (0)