Skip to content

Commit 3fc2669

Browse files
committed
fix lint on test_sdk.py: hoist import, disable no-self-use
Move ``SdkTracerProvider`` import to module top (ruff PLC0415 / pylint C0415) and add explicit ``# pylint: disable=no-self-use`` on the three mock-only tests that intentionally do not touch ``self``. Assisted-by: Claude Opus 4.7
1 parent 83e17bd commit 3fc2669

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

opentelemetry-sdk/tests/_configuration/test_sdk.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
from opentelemetry.sdk._configuration.models import (
3030
TracerProvider as TracerProviderConfig,
3131
)
32+
from opentelemetry.sdk.trace import TracerProvider as SdkTracerProvider
3233

3334

3435
_MIN_CONFIG_KWARGS = {"file_format": "1.0-rc.1"}
@@ -44,6 +45,7 @@ class TestConfigureSdk(unittest.TestCase):
4445
@patch("opentelemetry.sdk._configuration._sdk.configure_meter_provider")
4546
@patch("opentelemetry.sdk._configuration._sdk.configure_tracer_provider")
4647
@patch("opentelemetry.sdk._configuration._sdk.create_resource")
48+
# pylint: disable=no-self-use
4749
def test_calls_each_signal_with_resource(
4850
self,
4951
mock_create_resource,
@@ -77,6 +79,7 @@ def test_calls_each_signal_with_resource(
7779
@patch("opentelemetry.sdk._configuration._sdk.configure_meter_provider")
7880
@patch("opentelemetry.sdk._configuration._sdk.configure_tracer_provider")
7981
@patch("opentelemetry.sdk._configuration._sdk.create_resource")
82+
# pylint: disable=no-self-use
8083
def test_disabled_skips_everything(
8184
self,
8285
mock_create_resource,
@@ -103,6 +106,7 @@ def test_disabled_skips_everything(
103106
@patch("opentelemetry.sdk._configuration._sdk.configure_meter_provider")
104107
@patch("opentelemetry.sdk._configuration._sdk.configure_tracer_provider")
105108
@patch("opentelemetry.sdk._configuration._sdk.create_resource")
109+
# pylint: disable=no-self-use
106110
def test_disabled_false_runs_setup(
107111
self,
108112
mock_create_resource,
@@ -148,8 +152,6 @@ class TestConfigureSdkIntegration(unittest.TestCase):
148152
"opentelemetry.sdk._configuration._tracer_provider.trace.set_tracer_provider"
149153
)
150154
def test_applies_tracer_provider_globally(self, mock_set_tracer):
151-
from opentelemetry.sdk.trace import TracerProvider as SdkTracerProvider
152-
153155
config = _config(
154156
tracer_provider=TracerProviderConfig(
155157
processors=[

0 commit comments

Comments
 (0)