opentelemetry-sdk: update declarative config to use ServiceInstanceIdResourceDetector (#5299)

* opentelemetry-sdk: update declarative config to use ServiceInstanceIdResourceDetector

* add changelog fragment

---------

Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com>

Author: herin049

.changelog/5299.added

@@ -0,0 +1 @@
+`opentelemetry-sdk`: update declarative config to use `ServiceInstanceIdResourceDetector`

opentelemetry-sdk/src/opentelemetry/sdk/_configuration/_resource.py

@@ -7,7 +7,6 @@
 import fnmatch
 import logging
 import os
-import uuid
 from collections.abc import Callable
 from typing import Any
 from urllib import parse
@@ -23,10 +22,10 @@
 from opentelemetry.sdk.resources import (
     _DEFAULT_RESOURCE,
     OTEL_SERVICE_NAME,
-    SERVICE_INSTANCE_ID,
     SERVICE_NAME,
     ProcessResourceDetector,
     Resource,
+    ServiceInstanceIdResourceDetector,
     _HostResourceDetector,
 )
 from opentelemetry.util.types import AttributeValue
@@ -140,9 +139,9 @@ def create_resource(config: ResourceConfig | None) -> Resource:
 
 def _detect_service(_config: Any) -> dict[str, AttributeValue]:
     """Service detector: generates instance ID and reads OTEL_SERVICE_NAME."""
-    attrs: dict[str, AttributeValue] = {
-        SERVICE_INSTANCE_ID: str(uuid.uuid4()),
-    }
+    attrs: dict[str, AttributeValue] = dict(
+        ServiceInstanceIdResourceDetector().detect().attributes
+    )
     if service_name := os.environ.get(OTEL_SERVICE_NAME):
         attrs[SERVICE_NAME] = service_name
     return attrs

opentelemetry-sdk/tests/_configuration/test_resource.py

@@ -311,10 +311,10 @@ def test_service_detector_adds_instance_id(self):
         resource = create_resource(self._config_with_service())
         self.assertIn(SERVICE_INSTANCE_ID, resource.attributes)
 
-    def test_service_instance_id_is_unique_per_call(self):
+    def test_service_instance_id_is_stable_within_process(self):
         r1 = create_resource(self._config_with_service())
         r2 = create_resource(self._config_with_service())
-        self.assertNotEqual(
+        self.assertEqual(
             r1.attributes[SERVICE_INSTANCE_ID],
             r2.attributes[SERVICE_INSTANCE_ID],
         )