Skip to content

Commit 4d07cc0

Browse files
committed
Revert "fix(logs): optimize LogRecord memory by removing redundant context"
This reverts commit c77ecd0.
1 parent ef5598f commit 4d07cc0

4 files changed

Lines changed: 5 additions & 0 deletions

File tree

opentelemetry-api/src/opentelemetry/_logs/_internal/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ def __init__(
118118
if observed_timestamp is None:
119119
observed_timestamp = time_ns()
120120
self.observed_timestamp = observed_timestamp
121+
self.context = context
121122
self.trace_id = trace_id or span_context.trace_id
122123
self.span_id = span_id or span_context.span_id
123124
self.trace_flags = trace_flags or span_context.trace_flags

opentelemetry-sdk/tests/logs/test_handler.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -346,6 +346,7 @@ def test_log_record_trace_correlation(self):
346346
record.log_record.severity_number,
347347
SeverityNumber.FATAL,
348348
)
349+
self.assertEqual(record.log_record.context, mock_context)
349350
span_context = span.get_span_context()
350351
self.assertEqual(
351352
record.log_record.trace_id, span_context.trace_id

opentelemetry-sdk/tests/logs/test_log_record.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -221,6 +221,7 @@ def test_log_record_from_api_log_record(self):
221221

222222
self.assertEqual(record.log_record.timestamp, 1)
223223
self.assertEqual(record.log_record.observed_timestamp, 2)
224+
self.assertEqual(record.log_record.context, get_current())
224225
# trace_id, span_id, and trace_flags come from the context's span
225226
self.assertEqual(record.log_record.trace_id, 0)
226227
self.assertEqual(record.log_record.span_id, 0)

opentelemetry-sdk/tests/logs/test_logs.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,7 @@ def test_can_emit_api_logrecord(self):
180180
self.assertTrue(isinstance(log_record, LogRecord))
181181
self.assertEqual(log_record.timestamp, None)
182182
self.assertEqual(log_record.observed_timestamp, 0)
183+
self.assertIsNotNone(log_record.context)
183184
self.assertEqual(log_record.severity_number, None)
184185
self.assertEqual(log_record.severity_text, None)
185186
self.assertEqual(log_record.body, "a log line")
@@ -207,6 +208,7 @@ def test_can_emit_with_keywords_arguments(self):
207208
self.assertTrue(isinstance(result_log_record, LogRecord))
208209
self.assertEqual(result_log_record.timestamp, 100)
209210
self.assertEqual(result_log_record.observed_timestamp, 101)
211+
self.assertIsNotNone(result_log_record.context)
210212
self.assertEqual(
211213
result_log_record.severity_number, SeverityNumber.WARN
212214
)

0 commit comments

Comments
 (0)